fix: IOutput.Write(...) overloads now have argument IFormattingInfo set

Author: axunonb

src/SmartFormat.Tests/Core/Output/CustomOutputTests.cs

@@ -0,0 +1,55 @@
+using System;
+using System.Globalization;
+using System.Text;
+using NUnit.Framework;
+using SmartFormat.Core.Extensions;
+using SmartFormat.Core.Formatting;
+using SmartFormat.Core.Output;
+using SmartFormat.ZString;
+
+namespace SmartFormat.Tests.Core.Output;
+
+internal class CustomOutput : IOutput
+{
+    private readonly StringBuilder _sb = new(1000);
+    private const string OutputFormat = "Format: {0}, Selector {1}, Formatted: {2}";
+
+    public override string ToString()
+    {
+        return _sb.ToString();
+    }
+
+    public void Write(string text, IFormattingInfo? formattingInfo = null)
+    {
+        var fi = (FormattingInfo) formattingInfo!;
+        _sb.AppendFormat(OutputFormat, fi.Format, fi.Selector, text.ToString());
+    }
+
+    public void Write(ReadOnlySpan<char> text, IFormattingInfo? formattingInfo = null)
+    {
+        var fi = (FormattingInfo) formattingInfo!;
+        _sb.AppendFormat(OutputFormat, fi.Format, fi.Selector, text.ToString());
+    }
+
+    public void Write(ZStringBuilder stringBuilder, IFormattingInfo? formattingInfo = null)
+    {
+        var fi = (FormattingInfo) formattingInfo!;
+        _sb.AppendFormat(OutputFormat, fi.Format, fi.Selector, stringBuilder);
+    }
+}
+
+[TestFixture]
+internal class CustomOutputTests
+{
+    [Test]
+    public void CustomOutput_GetsValid_FormattingInfo_Argument()
+    {
+        // This test ensures that the IOutput.Write method overloads
+        // get a valid IFormattingInfo argument.
+        var smart = Smart.CreateDefaultSmartFormat();
+        var output = new CustomOutput();
+        smart.FormatInto(output, CultureInfo.InvariantCulture, "{0:0.0000}", [9m]);
+        Assert.That(output.ToString(),
+            Is.EqualTo("Format: 0.0000, Selector 0, Formatted: 9.0000"));
+    }
+}

src/SmartFormat.Tests/Core/Output/StringOutputTests.cs

@@ -12,15 +12,15 @@ public class StringOutputTests
     public void Output_Of_Span()
     {
         var so = new StringOutput();
-        so.Write("text".AsSpan(), null!);
+        so.Write("text".AsSpan(), null);
         Assert.That(so.ToString(), Is.EqualTo("text"));
     }
 
     [Test]
     public void Output_Of_String()
     {
         var so = new StringOutput(16);
-        so.Write("text", null!);
+        so.Write("text", null);
         Assert.That(so.ToString(), Is.EqualTo("text"));
     }
 
@@ -30,7 +30,7 @@ public void Output_Of_ValueStringBuilder()
         var so = new StringOutput();
         using var sb = ZStringBuilderUtilities.CreateZStringBuilder();
         sb.Append("text");
-        so.Write(sb, null!);
+        so.Write(sb, null);
         Assert.That(so.ToString(), Is.EqualTo("text"));
     }
 }

src/SmartFormat/Core/Formatting/FormattingInfo.cs

@@ -173,7 +173,7 @@ public void Write(ReadOnlySpan<char> text)
     {
         if (Alignment == 0)
         {
-            FormatDetails.Output.Write(text);
+            FormatDetails.Output.Write(text, this);
             FormatDetails.Formatter.Evaluator.OnOutputWritten?.Invoke(this,
                 new Evaluator.OutputWrittenEventArgs(text.ToString()));
             return;
@@ -199,7 +199,7 @@ public void Write(ReadOnlySpan<char> text)
         }
 
         // Write the aligned text to the output
-        FormatDetails.Output.Write(buffer.GetSpan());
+        FormatDetails.Output.Write(buffer.GetSpan(), this);
 
         FormatDetails.Formatter.Evaluator.OnOutputWritten?.Invoke(this,
             new Evaluator.OutputWrittenEventArgs(buffer.ToString()));