fix: consider live workflows when checking HasMoreWorkflows

Fix pagination logic to properly check for more workflows when there are
many live workflows in the cluster. Previously, HasMoreWorkflows only
checked the archive, ignoring live workflows.

- Check if current offset+limit is still within live workflows range
- If within live range, there are definitely more items
- If beyond live range, check archive with adjusted offset
- Fixes incorrect pagination when live workflows exceed offset+limit

Signed-off-by: shuangkun <[email protected]>

Author: shuangkun

server/workflow/workflow_server.go

@@ -255,11 +255,33 @@ func (s *workflowServer) ListWorkflows(ctx context.Context, req *workflowpkg.Wor
 	} else {
 		// For pagination without remaining count, use the efficient HasMoreWorkflows method
 		// This avoids expensive COUNT queries
-		hasMore, err := s.wfArchive.HasMoreWorkflows(ctx, options)
-		if err != nil {
-			return nil, sutils.ToStatusError(err, codes.Internal)
+		// Need to check both live workflows and archived workflows
+		hasMoreLive := false
+		if options.Limit > 0 {
+			// Check if there are more live workflows beyond the current offset+limit
+			hasMoreLive = int64(options.Offset+options.Limit) < liveWfCount
+		} else {
+			// If limit is 0, we're requesting all items, so no pagination needed
+			hasMoreLive = false
 		}
-		if hasMore {
+
+		hasMoreArchived := false
+		if !hasMoreLive {
+			// Only check archived workflows if we've exhausted live workflows
+			// Adjust offset to account for live workflows when checking archive
+			archivedOffset := options.Offset - int(liveWfCount)
+			if archivedOffset < 0 {
+				archivedOffset = 0
+			}
+			archivedOptions := options.WithOffset(archivedOffset)
+			hasMore, err := s.wfArchive.HasMoreWorkflows(ctx, archivedOptions)
+			if err != nil {
+				return nil, sutils.ToStatusError(err, codes.Internal)
+			}
+			hasMoreArchived = hasMore
+		}
+
+		if hasMoreLive || hasMoreArchived {
 			remainCount = 1 // There are more items
 		} else {
 			remainCount = 0 // No more items