chore: make examples that pass tests to run #15002

Many examples could pass tests but they were marked as no-test for
various reasons.

I analyzed all the tests and I marked the one that did not pass as
`no-test-broken` or `-no-test-environment` according to why they were
not passing.

The most common issues for failing example were the image used as part
of the workflow since we have a list of allowed images that can run as
tests I expanded the list accordingly and I moved some images that were
doing easy tasks for already allowed images.

For example we had some debian images that were running `sleep` or
`cat`, such commands can run from a busybox and it was already allowed
so I moved the workflow to use it.

As follow up I will update images to their up to date version.

Signed-off-by: Gianluca Arbezzano <[email protected]>

Author: gianarb

.github/workflows/ci-build.yaml

@@ -257,12 +257,12 @@ jobs:
           - test: test-cli
             profile: mysql
             use-api: true
-          # Cron tests are not retryable withou a controller restart
+          # Cron tests are not retryable without a controller restart
           - test: test-cron
             profile: minimal
             use-api: false
             retries: 0
-          # Example tests are not retryable withou a controller restart
+          # Example tests are not retryable without a controller restart
           - test: test-examples
             profile: minimal
             use-api: false

docs/fields.md

@@ -1,8 +1,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: archive-location-
 spec:
   entrypoint: hello-world

examples/archive-location.yaml

@@ -7,9 +7,9 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: arguments-artifacts-
+  labels:
+    workflows.argoproj.io/no-test-environment: "true"
 spec:
   entrypoint: kubectl-input-artifact
   arguments:
@@ -26,6 +26,6 @@ spec:
         path: /usr/local/bin/kubectl
         mode: 0755
     container:
-      image: debian:9.4
+      image: busybox
       command: [sh, -c]
       args: ["kubectl version"]

examples/arguments-artifacts.yaml

@@ -1,8 +1,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: arguments-parameters-
 spec:
   entrypoint: print-message

examples/arguments-parameters.yaml

@@ -6,8 +6,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: artifact-disable-archive-
 spec:
   entrypoint: artifact-disable-archive
@@ -59,7 +57,7 @@ spec:
       - name: hello-txt-nc
         path: /tmp/hello_nc.txt
     container:
-      image: alpine:latest
+      image: busybox
       command: [sh, -c]
       args:
       - cat /tmp/hello.txt && cat /tmp/hello_nc.txt && cd /tmp/etc && find .

examples/artifact-disable-archive.yaml

@@ -6,8 +6,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: artifact-gc-
 spec:
   entrypoint: main

examples/artifact-gc-workflow.yaml

@@ -3,8 +3,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: artifact-passing-
 spec:
   entrypoint: artifact-example
@@ -49,6 +47,6 @@ spec:
       - name: message
         path: /tmp/message
     container:
-      image: alpine:latest
+      image: busybox
       command: [sh, -c]
       args: ["cat /tmp/message"]

examples/artifact-passing-explicit-plugin.yaml

@@ -4,8 +4,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: artifact-passing-subpath-
 spec:
   entrypoint: artifact-example
@@ -46,7 +44,7 @@ spec:
       - name: message
         path: /tmp/message
     container:
-      image: alpine:latest
+      image: busybox
       command: [sh, -c]
       args: ["ls /tmp/message"]
 
@@ -56,6 +54,6 @@ spec:
       - name: message
         path: /tmp/message
     container:
-      image: alpine:latest
+      image: busybox
       command: [sh, -c]
       args: ["cat /tmp/message"]

examples/artifact-passing-subpath.yaml

@@ -3,8 +3,6 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  labels:
-    workflows.argoproj.io/no-test-broken: "true"
   generateName: artifact-passing-
 spec:
   entrypoint: artifact-example
@@ -36,6 +34,6 @@ spec:
       - name: message
         path: /tmp/message
     container:
-      image: alpine:latest
+      image: busybox
       command: [sh, -c]
       args: ["cat /tmp/message"]