-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
Background: Currently annotations are copied from the Rollout to the underlying Replicaset (code) unless it's part of a fixed list
- Recently our core engineering added a kyverno clusterpolicy to strip certain annotations from replicasets
- This led to an infinite loop where: the rollout controller added the annotation -> clusterpolicy removed it -> repeat
- The loop spammed the k8s api until the max annotation was hit for revision-history
- Note that in our k8s infra, these annotations were needed on the Rollout but not the underlying ReplicaSet (hence core k8s infra added the clusterpolicy to reduce load on etcd)
We would like to be able to supply additional annotations to skip via config to prevent the continuous looping issue
Submitted PR #4545 for this issue
Use Cases
- To be able to not copy over additional configurable annotations from the Rollout to the underlying ReplicaSet
- Prevents infinite loop situation
Message from the maintainers:
Need this enhancement? Give it a π. We prioritize the issues with the most π.
vpnda, mattem, yuhang-rh, lxiao-rh and alec-gibson
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request