Skip to content

Add configurable annotations to skipΒ #4546

@zelin-l

Description

@zelin-l

Summary

Background: Currently annotations are copied from the Rollout to the underlying Replicaset (code) unless it's part of a fixed list

  • Recently our core engineering added a kyverno clusterpolicy to strip certain annotations from replicasets
  • This led to an infinite loop where: the rollout controller added the annotation -> clusterpolicy removed it -> repeat
  • The loop spammed the k8s api until the max annotation was hit for revision-history
  • Note that in our k8s infra, these annotations were needed on the Rollout but not the underlying ReplicaSet (hence core k8s infra added the clusterpolicy to reduce load on etcd)

We would like to be able to supply additional annotations to skip via config to prevent the continuous looping issue

Submitted PR #4545 for this issue

Use Cases

  • To be able to not copy over additional configurable annotations from the Rollout to the underlying ReplicaSet
  • Prevents infinite loop situation

Message from the maintainers:

Need this enhancement? Give it a πŸ‘. We prioritize the issues with the most πŸ‘.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions