feat(cli): added support for filtering by group in app get-resource CLI command

[sabre1041]

Resolves #25494

[bunnyshell]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[nitishfy]

Suggested change

	command.Flags().StringVar(&group, "group", "", "Group")
	command.Flags().StringVar(&group, "group", "", "Group of resource")

nit

[sabre1041]

@nitishfy I modeled it similar to the flags in the other subcommands to ensure alignment of the CLI output

[nitishfy]

Left a small comment otherwise LGTM!

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@dea7ead). Learn more about missing BASE report.
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/app_resources.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #25495   +/-   ##
=========================================
  Coverage          ?   62.47%           
=========================================
  Files             ?      351           
  Lines             ?    49469           
  Branches          ?        0           
=========================================
  Hits              ?    30907           
  Misses            ?    15603           
  Partials          ?     2959           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reggie-k]

Thanks! Can you add some tests for this?

[sabre1041]

Thanks! Can you add some tests for this?

There arent any

Thanks! Can you add some tests for this?

Since the new logic that was added is included within the cobra command, there are no existing set of tests that target any of the CLI commands, so I am hesitant to take on establishing such an implementation for a fairly minor enhancement

[reggie-k]

Since the new logic that was added is included within the cobra command, there are no existing set of tests that target any of the CLI commands, so I am hesitant to take on establishing such an implementation for a fairly minor enhancement

Yeah, for unit tests it is true, but we have a lot of existing e2e tests that invoke CLI.