fix(oas3): warn for unsupported scheme

Author: kylef

packages/fury-adapter-oas3-parser/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Fury OAS3 Parser Changelog
 
+## TBD
+
+### Bug Fixes
+
+- Prevents the parser from throwing an error when encountering an unsupported
+  scheme in a http Security Scheme Object.
+
 ## 0.10.0 (2019-12-06)
 
 ### Enhancements

packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecuritySchemeObject.js

@@ -57,8 +57,20 @@ function validateApiKeyScheme(context, securityScheme) {
 function validateHttpScheme(context, securityScheme) {
   const { namespace } = context;
 
+  const schemes = ['bearer', 'basic'];
+  const isValidScheme = R.anyPass(R.map(hasValue, schemes));
+  const createInvalidSchemeWarning = scheme => createWarning(
+    namespace,
+    `'${name}' 'http' contains unsupported scheme '${scheme.value.toValue()}', supported schemes ${schemes.join(', ')}`,
+    scheme.value
+  );
+
+  const parseScheme = pipeParseResult(namespace,
+    parseString(context, name, false),
+    R.unless(isValidScheme, createInvalidSchemeWarning));
+
   const parseMember = R.cond([
-    [hasKey('scheme'), parseString(context, name, false)],
+    [hasKey('scheme'), parseScheme],
 
     [innerPassThrough, e => e],
     [isUnsupportedKey, e => e],

packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseSecuritySchemeObject-test.js

@@ -413,6 +413,20 @@ describe('Security Scheme Object', () => {
       expect(parseResult.length).to.equal(2);
       expect(parseResult).to.contain.warning("'Security Scheme Object' 'http' contains invalid key 'flows'");
     });
+
+    it('provides warning for invalid scheme', () => {
+      const securityScheme = new namespace.elements.Object({
+        type: 'http',
+        scheme: 'basic[',
+      });
+
+      const parseResult = parse(context, securityScheme);
+
+      expect(parseResult.length).to.equal(1);
+      expect(parseResult).to.contain.warning(
+        "'Security Scheme Object' 'http' contains unsupported scheme 'basic[', supported schemes bearer, basic"
+      );
+    });
   });
 
   describe('warnings for unsupported properties', () => {