fix(oas3): validate media types

Author: kylef

packages/fury-adapter-oas3-parser/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Fury OAS3 Parser Changelog
 
+## Master
+
+### Bug Fixes
+
+- Added validation of media types, previously we would throw an error while
+  handling invalid media types.
+
 ## 0.7.0 (2019-03-26)
 
 ### Enhancements

packages/fury-adapter-oas3-parser/lib/parser/oas/parseMediaTypeObject.js

@@ -1,7 +1,9 @@
 const R = require('ramda');
 const mediaTyper = require('media-typer');
 const pipeParseResult = require('../../pipeParseResult');
-const { isExtension, hasKey, getValue } = require('../../predicates');
+const {
+  isExtension, hasKey, getKey, getValue,
+} = require('../../predicates');
 const {
   createWarning,
   createUnsupportedMemberWarning,
@@ -44,6 +46,15 @@ function parseExample(namespace, mediaType) {
 const parseSchemaObjectOrRef = parseReference('schemas', parseSchemaObject);
 const parseExampleObjectOrRef = parseReference('examples', parseExampleObject);
 
+const isValidMediaType = (mediaType) => {
+  try {
+    mediaTyper.parse(mediaType.toValue());
+  } catch (error) {
+    return false;
+  }
+  return true;
+};
+
 /**
  * Parse Media Type Object
  *
@@ -59,6 +70,14 @@ function parseMediaTypeObject(context, MessageBodyClass, element) {
   const { namespace } = context;
   const mediaType = element.key.toValue();
 
+  const createInvalidMediaTypeWarning = mediaType => createWarning(namespace,
+    `'${name}' media type '${mediaType.toValue()}' is invalid`, mediaType);
+
+  const validateMediaType = R.unless(
+    R.compose(isValidMediaType, getKey),
+    R.compose(createInvalidMediaTypeWarning, getKey)
+  );
+
   const createExamplesNotJSONWarning = createWarning(namespace,
     `'${name}' 'examples' is only supported for JSON media types`);
 
@@ -99,6 +118,8 @@ function parseMediaTypeObject(context, MessageBodyClass, element) {
   ]);
 
   const parseMediaType = pipeParseResult(namespace,
+    validateMediaType,
+    getValue,
     parseObject(context, name, parseMember),
     (mediaTypeObject) => {
       const message = new MessageBodyClass();
@@ -146,7 +167,7 @@ function parseMediaTypeObject(context, MessageBodyClass, element) {
       return message;
     });
 
-  return parseMediaType(element.value);
+  return parseMediaType(element);
 }
 
 module.exports = R.curry(parseMediaTypeObject);

packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseMediaTypeObject-test.js

@@ -21,6 +21,14 @@ describe('Media Type Object', () => {
     expect(parseResult).to.contain.warning("'Media Type Object' is not an object");
   });
 
+  it('provides warning when media type is invalid', () => {
+    const mediaType = new namespace.elements.Member('foo', {});
+
+    const parseResult = parse(context, messageBodyClass, mediaType);
+
+    expect(parseResult).to.contain.warning("'Media Type Object' media type 'foo' is invalid");
+  });
+
   it('returns a HTTP message body', () => {
     const mediaType = new namespace.elements.Member('application/json', {});