Merge pull request #207 from apiaryio/kylef/oas3-openapi-3.1

Parsing openapi version should return version on success

Author: pksunkara

packages/fury-adapter-oas3-parser/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Fury OAS3 Parser Changelog
 
+## Master
+
+### Bug Fixes
+
+- Fixes a bug where parsing an OpenAPI 3.1.0 or higher document will result in
+  an parse result containing only a warning and missing the API Category.
+
 ## 0.7.2 (2019-04-01)
 
 ### Bug Fixes

packages/fury-adapter-oas3-parser/lib/parser/openapi.js

@@ -26,7 +26,7 @@ function parseOpenAPI(context, openapi) {
   }
 
   if (parseInt(versionInfo[2], 10) > supportedMinorVersion) {
-    return new namespace.elements.ParseResult([createWarning(namespace, `Version '${openapi.value.toValue()}' is not fully supported`, openapi.value)]);
+    return new namespace.elements.ParseResult([openapi, createWarning(namespace, `Version '${openapi.value.toValue()}' is not fully supported`, openapi.value)]);
   }
 
 

packages/fury-adapter-oas3-parser/test/unit/parser/openapi-test.js

@@ -43,6 +43,7 @@ describe('#parseOpenAPI', () => {
     const parseResult = parseOpenAPI(context, openapi);
     expect(parseResult).to.be.instanceof(namespace.elements.ParseResult);
     expect(parseResult).to.not.contain.annotations;
+    expect(parseResult.get(0).value.toValue()).to.equal('3.0.0');
   });
 
   it('allows openapi patch version 3.0.11', () => {
@@ -51,6 +52,7 @@ describe('#parseOpenAPI', () => {
     const parseResult = parseOpenAPI(context, openapi);
     expect(parseResult).to.be.instanceof(namespace.elements.ParseResult);
     expect(parseResult).to.not.contain.annotations;
+    expect(parseResult.get(0).value.toValue()).to.equal('3.0.11');
   });
 
   it('warns for unsuported minor versions', () => {
@@ -59,5 +61,6 @@ describe('#parseOpenAPI', () => {
     const parseResult = parseOpenAPI(context, openapi);
     expect(parseResult).to.be.instanceof(namespace.elements.ParseResult);
     expect(parseResult).to.contain.warning("Version '3.1.0' is not fully supported");
+    expect(parseResult.get(0).value.toValue()).to.equal('3.1.0');
   });
 });