fix(oas3): handle malformed query name (#214)

Author: klokane

packages/fury-adapter-oas3-parser/lib/parser/oas/parseParameterObject.js

@@ -110,6 +110,8 @@ function parseParameterObject(context, object) {
 
   const createReservedHeaderNamesWarning = createWarning(namespace, `'${name}' 'name' in location 'header' should not be 'Accept', 'Content-Type' or 'Authorization'`);
 
+  const createMalformedUriCharacterError = createError(namespace, `'${name}' 'name' in location 'query' contains URI malformed characters`);
+
   const hasLocation = R.curry((location, parameter) => parameter.getValue('in') === location);
 
   const validatePathName = R.when(nameContainsReservedCharacter, createUnsupportedNameError);
@@ -118,11 +120,12 @@ function parseParameterObject(context, object) {
     .toValue()
     .match(reservedHeaderNamesRegex);
 
-  const sanitizeQueryName = (parameter) => {
+  const sanitizeQueryName = R.tryCatch((parameter) => {
     const name = parameter.get('name');
     name.content = encodeQueryName(name.toValue());
     return parameter;
-  };
+  },
+  (err, parameter) => createMalformedUriCharacterError(parameter.get('name')));
 
   const validateHeaderName = pipeParseResult(namespace,
     R.when(nameContainsReservedCharacter, createUnsupportedNameError),

packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseParameterObject-test.js

@@ -93,6 +93,17 @@ describe('Parameter Object', () => {
       expect(parseResult.get(0).key.toValue()).to.equal(input);
     });
 
+    it('handle throw while encoding query', () => {
+      const parameter = new namespace.elements.Object({
+        name: '\uD800',
+        in: 'query',
+      });
+
+      const parseResult = parse(context, parameter);
+
+      expect(parseResult).to.contain.error('\'Parameter Object\' \'name\' in location \'query\' contains URI malformed characters');
+    });
+
     it('allows header name to contain unreserved characters', () => {
       const alpha = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
       const digit = '0123456789';