|
| 1 | +/* |
| 2 | + * Licensed to the Apache Software Foundation (ASF) under one |
| 3 | + * or more contributor license agreements. See the NOTICE file |
| 4 | + * distributed with this work for additional information |
| 5 | + * regarding copyright ownership. The ASF licenses this file |
| 6 | + * to you under the Apache License, Version 2.0 (the |
| 7 | + * "License"); you may not use this file except in compliance |
| 8 | + * with the License. You may obtain a copy of the License at |
| 9 | + * |
| 10 | + * http://www.apache.org/licenses/LICENSE-2.0 |
| 11 | + * |
| 12 | + * Unless required by applicable law or agreed to in writing, software |
| 13 | + * distributed under the License is distributed on an "AS IS" BASIS, |
| 14 | + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | + * See the License for the specific language governing permissions and |
| 16 | + * limitations under the License. |
| 17 | + */ |
| 18 | + |
| 19 | +package org.apache.zookeeper.server; |
| 20 | + |
| 21 | +import static org.junit.jupiter.api.Assertions.assertEquals; |
| 22 | +import static org.junit.jupiter.api.Assertions.assertThrows; |
| 23 | +import static org.mockito.Mockito.doThrow; |
| 24 | +import static org.mockito.Mockito.mock; |
| 25 | +import static org.mockito.Mockito.mockingDetails; |
| 26 | +import java.util.Arrays; |
| 27 | +import org.junit.jupiter.api.AfterEach; |
| 28 | +import org.junit.jupiter.params.ParameterizedTest; |
| 29 | +import org.junit.jupiter.params.provider.EnumSource; |
| 30 | + |
| 31 | +public class ServerCnxnFactoryTest { |
| 32 | + public enum FactoryType { |
| 33 | + NIO, NETTY |
| 34 | + } |
| 35 | + |
| 36 | + private ServerCnxnFactory factory; |
| 37 | + |
| 38 | + @AfterEach |
| 39 | + public void tearDown() { |
| 40 | + if (factory != null) { |
| 41 | + try { |
| 42 | + factory.shutdown(); |
| 43 | + } catch (Exception e) { |
| 44 | + // Ignore all shutdown exceptions in tests since factory may not be fully initialized |
| 45 | + } |
| 46 | + } |
| 47 | + } |
| 48 | + |
| 49 | + @ParameterizedTest |
| 50 | + @EnumSource(FactoryType.class) |
| 51 | + public void testShedConnections_InvalidPercentage(final FactoryType factoryType) { |
| 52 | + factory = createFactory(factoryType); |
| 53 | + assertThrows(IllegalArgumentException.class, () -> factory.shedConnections(-1)); |
| 54 | + assertThrows(IllegalArgumentException.class, () -> factory.shedConnections(101)); |
| 55 | + } |
| 56 | + |
| 57 | + @ParameterizedTest |
| 58 | + @EnumSource(FactoryType.class) |
| 59 | + public void testShedConnections_ValidPercentages(final FactoryType factoryType) { |
| 60 | + factory = createFactory(factoryType); |
| 61 | + |
| 62 | + assertEquals(0, factory.shedConnections(0)); |
| 63 | + assertEquals(0, factory.shedConnections(50)); |
| 64 | + assertEquals(0, factory.shedConnections(100)); |
| 65 | + } |
| 66 | + |
| 67 | + @ParameterizedTest |
| 68 | + @EnumSource(FactoryType.class) |
| 69 | + public void testShedConnections_DeterministicBehavior(final FactoryType factoryType) { |
| 70 | + factory = createFactory(factoryType); |
| 71 | + |
| 72 | + // Create 4 mock connections for testing deterministic edge cases |
| 73 | + final ServerCnxn[] mockCnxns = new ServerCnxn[4]; |
| 74 | + for (int i = 0; i < 4; i++) { |
| 75 | + mockCnxns[i] = mock(ServerCnxn.class); |
| 76 | + factory.cnxns.add(mockCnxns[i]); |
| 77 | + } |
| 78 | + |
| 79 | + // Test 0% shedding - should shed exactly 0 connections (deterministic) |
| 80 | + int shedCount = factory.shedConnections(0); |
| 81 | + assertEquals(0, shedCount, "0% shedding should shed exactly 0 connections"); |
| 82 | + |
| 83 | + // Verify no connections were actually closed |
| 84 | + int actualClosedCount = countConnectionsShed(mockCnxns); |
| 85 | + assertEquals(0, actualClosedCount, "No connections should be closed for 0% shedding"); |
| 86 | + |
| 87 | + // Test 100% shedding - should shed exactly all connections (deterministic) |
| 88 | + shedCount = factory.shedConnections(100); |
| 89 | + assertEquals(4, shedCount, "100% shedding should shed exactly all 4 connections"); |
| 90 | + |
| 91 | + // Verify all connections were actually closed with correct reason |
| 92 | + actualClosedCount = countConnectionsShed(mockCnxns); |
| 93 | + assertEquals(4, actualClosedCount, "All 4 connections should be closed for 100% shedding"); |
| 94 | + } |
| 95 | + |
| 96 | + @ParameterizedTest |
| 97 | + @EnumSource(FactoryType.class) |
| 98 | + public void testShedConnections_SmallPercentageRoundsToZero(final FactoryType factoryType) { |
| 99 | + factory = createFactory(factoryType); |
| 100 | + |
| 101 | + // Add single mock connection |
| 102 | + final ServerCnxn mockCnxn = mock(ServerCnxn.class); |
| 103 | + factory.cnxns.add(mockCnxn); |
| 104 | + |
| 105 | + // small percentage rounds to 0 |
| 106 | + assertEquals(0, factory.shedConnections(1), "1% of 1 connection should round to 0"); |
| 107 | + } |
| 108 | + |
| 109 | + @ParameterizedTest |
| 110 | + @EnumSource(FactoryType.class) |
| 111 | + public void testShedConnections_ErrorHandling(final FactoryType factoryType) { |
| 112 | + factory = createFactory(factoryType); |
| 113 | + |
| 114 | + // Create mock connections where one will fail to close |
| 115 | + final ServerCnxn[] mockCnxns = new ServerCnxn[4]; |
| 116 | + for (int i = 0; i < 4; i++) { |
| 117 | + mockCnxns[i] = mock(ServerCnxn.class); |
| 118 | + factory.cnxns.add(mockCnxns[i]); |
| 119 | + } |
| 120 | + |
| 121 | + // Make the second connection throw an exception when closed |
| 122 | + doThrow(new RuntimeException("Connection close failed")) |
| 123 | + .when(mockCnxns[1]).close(ServerCnxn.DisconnectReason.SHED_CONNECTIONS_COMMAND); |
| 124 | + |
| 125 | + // Test 100% shedding to ensure error handling works deterministically |
| 126 | + final int shedCount = factory.shedConnections(100); |
| 127 | + |
| 128 | + // Since one connection throws an exception, only 3 should be successfully closed |
| 129 | + assertEquals(3, shedCount, "Should successfully close 3 connections, 1 should fail"); |
| 130 | + int actualClosedCount = countConnectionsShed(mockCnxns); |
| 131 | + assertEquals(4, actualClosedCount, "All 4 connections should have close() called, even if one throws exception"); |
| 132 | + } |
| 133 | + |
| 134 | + private ServerCnxnFactory createFactory(final FactoryType type) { |
| 135 | + switch (type) { |
| 136 | + case NIO: |
| 137 | + return new NIOServerCnxnFactory(); |
| 138 | + case NETTY: |
| 139 | + return new NettyServerCnxnFactory(); |
| 140 | + default: |
| 141 | + throw new IllegalArgumentException("Unknown factory type: " + type); |
| 142 | + } |
| 143 | + } |
| 144 | + |
| 145 | + private int countConnectionsShed(final ServerCnxn[] connections) { |
| 146 | + return (int) Arrays.stream(connections) |
| 147 | + .filter(cnxn -> mockingDetails(cnxn).getInvocations().stream() |
| 148 | + .anyMatch(invocation -> |
| 149 | + invocation.getMethod().getName().equals("close") |
| 150 | + && invocation.getArguments().length == 1 |
| 151 | + && invocation.getArguments()[0].equals(ServerCnxn.DisconnectReason.SHED_CONNECTIONS_COMMAND) |
| 152 | + )) |
| 153 | + .count(); |
| 154 | + } |
| 155 | +} |
| 156 | + |
0 commit comments