Skip to content

Commit fcb08ac

Browse files
authored
Fix AvgHistogramPercentileFunction doesn't have proper field definition for ranks. (#12927)
1 parent 4c5882d commit fcb08ac

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

docs/en/changes/changes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
* Fix missing remote endpoint IP address in span query of zipkin query module.
5252
* Fix `hierarchy-definition.yml` config file packaged into start.jar wrongly.
5353
* Add `bydb.dependencies.properties` config file to define server dependency versions.
54+
* Fix `AvgHistogramPercentileFunction` doesn't have proper field definition for `ranks`.
5455

5556
#### UI
5657

oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ public abstract class AvgHistogramPercentileFunction extends Meter implements Ac
109109
@Getter
110110
@Setter
111111
@Column(name = RANKS, storageOnly = true)
112+
@BanyanDB.MeasureField
112113
private IntList ranks = new IntList(10);
113114

114115
private boolean isCalculated = false;

oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ enum IndexType {
124124

125125
/**
126126
* MeasureField defines a column as a measure's field.
127+
* The measure field has a significant difference from no-indexing tag.
128+
* The measure fields are stored in another file, but no-indexing tag is stored in the same file with the indexing tags.
127129
* <p>
128130
* Annotated: the column is a measure field.
129131
* Unannotated: the column is a measure tag.
@@ -219,6 +221,8 @@ enum AnalyzerType {
219221
/**
220222
* IndexMode is used to indicate the index mode of the metric.
221223
* All columns in the metric will be stored in the index exclusively.
224+
* When an entity column is not used in query condition, only {@link Column#storageOnly()} is allowed.
225+
* No {@link MeasureField} is allowed for those columns in IndexMode entity.
222226
*
223227
* @since 10.2.0
224228
*/

0 commit comments

Comments
 (0)