Skip to content

Commit caae5da

Browse files
committed
Fix our variable naming in the CMake build. CMake's pkg-config finder
sets BROTLI_INCLUDE_DIR when searching for the Brotli libraries. * CMakeLists.txt, build/FindBrotli.cmake: Use BROTLI_INCLUDE_DIR instead of BROTLI_INCLUDES. git-svn-id: https://svn.apache.org/repos/asf/serf/trunk@1930991 13f79535-47bb-0310-9956-ffa450edef68
1 parent 8fd548f commit caae5da

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,11 +391,11 @@ CheckFunction("SSL_library_init" "" "SERF_HAVE_OPENSSL_SSL_LIBRARY_INIT"
391391
CheckHeader("stdbool.h" "HAVE_STDBOOL_H=1")
392392
CheckType("OSSL_HANDSHAKE_STATE" "openssl/ssl.h" "SERF_HAVE_OSSL_HANDSHAKE_STATE" ${OPENSSL_INCLUDE_DIR})
393393
if(Brotli_FOUND)
394-
CheckType("BrotliDecoderResult" "brotli/decode.h" "SERF_HAVE_BROTLI_DECODER_RESULT" ${BROTLI_INCLUDES})
394+
CheckType("BrotliDecoderResult" "brotli/decode.h" "SERF_HAVE_BROTLI_DECODER_RESULT" ${BROTLI_INCLUDE_DIR})
395395
# Check for the function only if the type check succeeded.
396396
if("SERF_HAVE_BROTLI_DECODER_RESULT" IN_LIST SERF_C_DEFINES)
397397
CheckFunction("BrotliDecoderTakeOutput" "NULL, NULL" "SERF_HAVE_BROTLI"
398-
"brotli/decode.h" ${BROTLI_INCLUDES}
398+
"brotli/decode.h" ${BROTLI_INCLUDE_DIR}
399399
Brotli::Decode ${SERF_STANDARD_LIBRARIES})
400400
endif()
401401
endif()

build/FindBrotli.cmake

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function(_get_brotli_includes_libs)
5353
find_library(encode_lib NAMES "brotlienc"
5454
PATH_SUFFIXES "lib" "${CMAKE_INSTALL_LIBDIR}")
5555

56-
set(BROTLI_INCLUDES "${includes}" PARENT_SCOPE)
56+
set(BROTLI_INCLUDE_DIR "${includes}" PARENT_SCOPE)
5757
set(BROTLI_COMMON_LIBRARY "${common_lib}" PARENT_SCOPE)
5858
set(BROTLI_DECODE_LIBRARY "${decode_lib}" PARENT_SCOPE)
5959
set(BROTLI_ENCODE_LIBRARY "${encode_lib}" PARENT_SCOPE)
@@ -65,33 +65,33 @@ endif()
6565

6666
_get_brotli_version()
6767
_get_brotli_includes_libs()
68-
if(NOT EXISTS "${BROTLI_INCLUDES}/brotli/decode.h"
69-
OR NOT EXISTS "${BROTLI_INCLUDES}/brotli/encode.h"
70-
OR NOT EXISTS "${BROTLI_INCLUDES}/brotli/types.h")
68+
if(NOT EXISTS "${BROTLI_INCLUDE_DIR}/brotli/decode.h"
69+
OR NOT EXISTS "${BROTLI_INCLUDE_DIR}/brotli/encode.h"
70+
OR NOT EXISTS "${BROTLI_INCLUDE_DIR}/brotli/types.h")
7171
message(STATUS "Could NOT find Brotli (missing headers)")
7272
else()
7373
include(FindPackageHandleStandardArgs)
7474
find_package_handle_standard_args(Brotli
7575
REQUIRED_VARS BROTLI_COMMON_LIBRARY
7676
BROTLI_DECODE_LIBRARY
7777
BROTLI_ENCODE_LIBRARY
78-
BROTLI_INCLUDES
78+
BROTLI_INCLUDE_DIR
7979
VERSION_VAR BROTLI_VERSION)
8080
if(Brotli_FOUND)
8181
add_library(Brotli::Common UNKNOWN IMPORTED)
8282
set_target_properties(Brotli::Common PROPERTIES
83-
INTERFACE_INCLUDE_DIRECTORIES "${BROTLI_INCLUDES}"
83+
INTERFACE_INCLUDE_DIRECTORIES "${BROTLI_INCLUDE_DIR}"
8484
IMPORTED_LOCATION "${BROTLI_COMMON_LIBRARY}")
8585

8686
add_library(Brotli::Decode UNKNOWN IMPORTED)
8787
set_target_properties(Brotli::Decode PROPERTIES
88-
INTERFACE_INCLUDE_DIRECTORIES "${BROTLI_INCLUDES}"
88+
INTERFACE_INCLUDE_DIRECTORIES "${BROTLI_INCLUDE_DIR}"
8989
INTERFACE_LINK_LIBRARIES Brotli::Common
9090
IMPORTED_LOCATION "${BROTLI_DECODE_LIBRARY}")
9191

9292
add_library(Brotli::Encode UNKNOWN IMPORTED)
9393
set_target_properties(Brotli::Encode PROPERTIES
94-
INTERFACE_INCLUDE_DIRECTORIES "${BROTLI_INCLUDES}"
94+
INTERFACE_INCLUDE_DIRECTORIES "${BROTLI_INCLUDE_DIR}"
9595
INTERFACE_LINK_LIBRARIES Brotli::Common
9696
IMPORTED_LOCATION "${BROTLI_ENCODE_LIBRARY}")
9797
endif()

0 commit comments

Comments
 (0)