[FIX] Leak: TrueTypeCollection didn't close FileChannel

Author: bogdiuk

fontbox/src/main/java/org/apache/fontbox/ttf/TrueTypeCollection.java

@@ -21,6 +21,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import org.apache.pdfbox.io.IOUtils;
 
 import org.apache.pdfbox.io.RandomAccessRead;
 import org.apache.pdfbox.io.RandomAccessReadBuffer;
@@ -46,7 +47,7 @@ public class TrueTypeCollection implements Closeable
      */
     public TrueTypeCollection(File file) throws IOException
     {
-        this(new RandomAccessReadBufferedFile(file));
+        this(new RandomAccessReadBufferedFile(file), true);
     }
 
     /**
@@ -57,7 +58,7 @@ public TrueTypeCollection(File file) throws IOException
      */
     public TrueTypeCollection(InputStream stream) throws IOException
     {
-        this(new RandomAccessReadBuffer(stream));
+        this(new RandomAccessReadBuffer(stream), false);
     }
 
     /**
@@ -68,7 +69,29 @@ public TrueTypeCollection(InputStream stream) throws IOException
      */
     TrueTypeCollection(RandomAccessRead randomAccessRead) throws IOException
     {
-        this.stream = new RandomAccessReadDataStream(randomAccessRead);
+        this(randomAccessRead, false);
+    }
+
+    /**
+     * Creates a new TrueTypeCollection from a RandomAccessRead.
+     *
+     * @param randomAccessRead 
+     * @param closeAfterReading {@code true} to close randomAccessRead
+     * @throws IOException If the font could not be parsed.
+     */
+    private TrueTypeCollection(RandomAccessRead randomAccessRead, boolean closeAfterReading) throws IOException
+    {
+        try
+        {
+            this.stream = new RandomAccessReadDataStream(randomAccessRead);
+        }
+        finally
+        {
+            if (closeAfterReading)
+            {
+                IOUtils.closeQuietly(randomAccessRead);
+            }
+        }
 
         // TTC header
         String tag = stream.readTag();