[fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support#60903
Open
CalvinKirs wants to merge 3 commits intoapache:masterfrom
Open
[fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support#60903CalvinKirs wants to merge 3 commits intoapache:masterfrom
CalvinKirs wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
1 similar comment
Member
Author
|
run buildall |
TPC-H: Total hot run time: 28716 ms |
TPC-DS: Total hot run time: 183370 ms |
gavinchou
reviewed
Feb 28, 2026
| } | ||
|
|
||
| private static final String AZURE_ENDPOINT_SUFFIX = ".blob.core.windows.net"; | ||
| private static final String[] AZURE_ACCOUNT_KEY_ENDPOINTS = { |
Contributor
There was a problem hiding this comment.
why not read from config?
Making it configurable with default list will make it extensible.
CalvinKirs
force-pushed
the
master-azure
branch
from
aec50bb to
40b746a
Compare
Member
Author
|
run buildall |
# Conflicts: # fe/fe-common/src/main/java/org/apache/doris/common/Config.java
Member
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 29005 ms |
morningman
approved these changes
Mar 3, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 184631 ms |
gavinchou
reviewed
Mar 3, 2026
| if (s3_conf.endpoint.find("://") == std::string::npos) { | ||
| uri = "https://" + uri; | ||
| } | ||
| std::string uri = fmt::format("{}/{}", s3_conf.endpoint, container_name); |
Contributor
There was a problem hiding this comment.
strip the trailing / of the URI to increase robustness
Member
Author
There was a problem hiding this comment.
If necessary, this should be placed in normalized_uri.
| if (uri_.find("://") == std::string::npos) { | ||
| uri_ = "https://" + uri_; | ||
| } | ||
| uri_ = fmt::format("{}/{}", conf_.endpoint, conf_.bucket); |
| }) | ||
| public static boolean force_azure_blob_global_endpoint = false; | ||
| public static String[] azure_blob_host_suffixes = { | ||
| ".blob.core.windows.net", |
Contributor
There was a problem hiding this comment.
do we need to keep both
.dfs and .blob?
why not sth like just core.winodows.com?
Member
Author
There was a problem hiding this comment.
This is required by the HDFS style guidelines.
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)