Skip to content

Commit 034013e

Browse files
committed
opt method name
1 parent 4f60a7c commit 034013e

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

fe/fe-core/src/main/java/org/apache/doris/nereids/lineage/LineageEventProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ pluginRoots, getClass().getClassLoader(),
191191
LOG.warn("Failed to create/initialize lineage plugin: {}", pluginName, e);
192192
}
193193
}
194-
refreshPlugins(plugins);
194+
initPlugins(plugins);
195195
}
196196

197197
private String safeFactoryName(LineagePluginFactory factory) {
@@ -221,7 +221,7 @@ private String resolvePluginPath(String pluginName) {
221221
/**
222222
* Update the active lineage plugin list.
223223
*/
224-
public void refreshPlugins(List<LineagePlugin> plugins) {
224+
public void initPlugins(List<LineagePlugin> plugins) {
225225
List<LineagePlugin> safePlugins = plugins == null ? Collections.emptyList() : plugins;
226226
lineagePlugins.set(safePlugins);
227227
if (safePlugins.isEmpty()) {

fe/fe-core/src/test/java/org/apache/doris/nereids/lineage/LineageEventProcessorTest.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,46 +52,46 @@ public void testHasActivePluginsDefaultEmpty() {
5252
}
5353

5454
@Test
55-
public void testRefreshPluginsWithOnePlugin() {
55+
public void testInitPluginsWithOnePlugin() {
5656
LineageEventProcessor processor = new LineageEventProcessor();
5757
LineagePlugin mockPlugin = new NoOpLineagePlugin("test-plugin");
5858

59-
processor.refreshPlugins(Collections.singletonList(mockPlugin));
59+
processor.initPlugins(Collections.singletonList(mockPlugin));
6060
Assertions.assertTrue(processor.hasActivePlugins(),
6161
"Should have active plugins after refresh with one plugin");
6262
}
6363

6464
@Test
65-
public void testRefreshPluginsWithNull() {
65+
public void testInitPluginsWithNull() {
6666
LineageEventProcessor processor = new LineageEventProcessor();
67-
processor.refreshPlugins(Collections.singletonList(new NoOpLineagePlugin("p1")));
67+
processor.initPlugins(Collections.singletonList(new NoOpLineagePlugin("p1")));
6868
Assertions.assertTrue(processor.hasActivePlugins());
6969

70-
processor.refreshPlugins(null);
70+
processor.initPlugins(null);
7171
Assertions.assertFalse(processor.hasActivePlugins(),
7272
"Refreshing with null should clear plugins");
7373
}
7474

7575
@Test
76-
public void testRefreshPluginsWithEmptyList() {
76+
public void testInitPluginsWithEmptyList() {
7777
LineageEventProcessor processor = new LineageEventProcessor();
78-
processor.refreshPlugins(Collections.singletonList(new NoOpLineagePlugin("p1")));
78+
processor.initPlugins(Collections.singletonList(new NoOpLineagePlugin("p1")));
7979
Assertions.assertTrue(processor.hasActivePlugins());
8080

81-
processor.refreshPlugins(Collections.emptyList());
81+
processor.initPlugins(Collections.emptyList());
8282
Assertions.assertFalse(processor.hasActivePlugins(),
8383
"Refreshing with empty list should clear plugins");
8484
}
8585

8686
@Test
87-
public void testRefreshPluginsWithMultiplePlugins() {
87+
public void testInitPluginsWithMultiplePlugins() {
8888
LineageEventProcessor processor = new LineageEventProcessor();
8989
List<LineagePlugin> plugins = Arrays.asList(
9090
new NoOpLineagePlugin("plugin-a"),
9191
new NoOpLineagePlugin("plugin-b"),
9292
new NoOpLineagePlugin("plugin-c")
9393
);
94-
processor.refreshPlugins(plugins);
94+
processor.initPlugins(plugins);
9595
Assertions.assertTrue(processor.hasActivePlugins());
9696
}
9797

@@ -100,15 +100,15 @@ public void testHasActivePluginsAllFilteredOut() {
100100
LineageEventProcessor processor = new LineageEventProcessor();
101101
LineagePlugin filterPlugin = new TrackingLineagePlugin("filter-out",
102102
false, new AtomicInteger(), new ArrayList<>(), new CountDownLatch(SINGLE_LATCH_COUNT));
103-
processor.refreshPlugins(Collections.singletonList(filterPlugin));
103+
processor.initPlugins(Collections.singletonList(filterPlugin));
104104
Assertions.assertFalse(processor.hasActivePlugins(),
105105
"Should be false when all plugins are filtered out");
106106
}
107107

108108
@Test
109109
public void testHasActivePluginsWhenFilterThrows() {
110110
LineageEventProcessor processor = new LineageEventProcessor();
111-
processor.refreshPlugins(Collections.singletonList(new EventFilterExceptionLineagePlugin("boom")));
111+
processor.initPlugins(Collections.singletonList(new EventFilterExceptionLineagePlugin("boom")));
112112
Assertions.assertFalse(processor.hasActivePlugins(),
113113
"Should be false when plugin filter throws exception");
114114
}
@@ -151,7 +151,7 @@ public void testWorkerDispatchesToPlugin() throws Exception {
151151
LineagePlugin trackingPlugin = new TrackingLineagePlugin("tracker",
152152
true, execCount, processedQueryIds, latch);
153153

154-
processor.refreshPlugins(Collections.singletonList(trackingPlugin));
154+
processor.initPlugins(Collections.singletonList(trackingPlugin));
155155

156156
// Start processor (without SPI discovery, since we already set plugins via refreshPlugins)
157157
Thread workerThread = new Thread(processor.new Worker(), "test-worker");
@@ -185,7 +185,7 @@ public void testWorkerSkipsPluginWhenEventFilterReturnsFalse() throws Exception
185185
LineagePlugin acceptPlugin = new TrackingLineagePlugin("accept",
186186
true, acceptExecCount, new ArrayList<>(), acceptLatch);
187187

188-
processor.refreshPlugins(Arrays.asList(filterPlugin, acceptPlugin));
188+
processor.initPlugins(Arrays.asList(filterPlugin, acceptPlugin));
189189

190190
Thread workerThread = new Thread(processor.new Worker(), "test-worker-filter");
191191
workerThread.setDaemon(true);
@@ -213,7 +213,7 @@ public void testWorkerHandlesPluginException() throws Exception {
213213
LineagePlugin goodPlugin = new TrackingLineagePlugin("good-plugin",
214214
true, goodExecCount, new ArrayList<>(), latch);
215215

216-
processor.refreshPlugins(Arrays.asList(badPlugin, goodPlugin));
216+
processor.initPlugins(Arrays.asList(badPlugin, goodPlugin));
217217

218218
Thread workerThread = new Thread(processor.new Worker(), "test-worker-exception");
219219
workerThread.setDaemon(true);

0 commit comments

Comments
 (0)