remove redundant code

Author: wugeer

src/ast/mod.rs

@@ -3407,7 +3407,7 @@ pub enum Statement {
     /// Renames one or more tables
     ///
     /// See Mysql <https://dev.mysql.com/doc/refman/9.1/en/rename-table.html>
-    RenameTable(Vec<RenameObjectDef>),
+    RenameTable(Vec<RenameTable>),
 }
 
 impl fmt::Display for Statement {
@@ -7660,12 +7660,12 @@ impl Display for JsonNullClause {
 #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub struct RenameObjectDef {
+pub struct RenameTable {
     pub old_name: ObjectName,
     pub new_name: ObjectName,
 }
 
-impl fmt::Display for RenameObjectDef {
+impl fmt::Display for RenameTable {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         write!(f, "{} TO {}", self.old_name, self.new_name)?;
         Ok(())

src/dialect/mod.rs

@@ -715,11 +715,6 @@ pub trait Dialect: Debug + Any {
         true
     }
 
-    // Returns true if the dialect supports the `RENAME TABLE` statement
-    fn supports_rename_table(&self) -> bool {
-        false
-    }
-
     /// Returns true if this dialect supports the `LIKE 'pattern'` option in
     /// a `SHOW` statement before the `IN` option
     fn supports_show_like_before_in(&self) -> bool {

src/dialect/mysql.rs

@@ -102,11 +102,6 @@ impl Dialect for MySqlDialect {
     fn supports_create_table_select(&self) -> bool {
         true
     }
-
-    /// see <https://dev.mysql.com/doc/refman/9.1/en/rename-table.html>
-    fn supports_rename_table(&self) -> bool {
-        true
-    }
 }
 
 /// `LOCK TABLES`

src/parser/mod.rs

@@ -1047,15 +1047,16 @@ impl<'a> Parser<'a> {
     }
 
     /// Parses a `RENAME TABLE` statement. See [Statement::RenameTable]
+    /// see <https://dev.mysql.com/doc/refman/9.1/en/rename-table.html>
     pub fn parse_rename(&mut self) -> Result<Statement, ParserError> {
-        if self.dialect.supports_rename_table() && self.peek_keyword(Keyword::TABLE) {
+        if self.peek_keyword(Keyword::TABLE) {
             self.expect_keyword(Keyword::TABLE)?;
             let rename_object_defs = self.parse_comma_separated(|parser| {
                 let old_name = parser.parse_object_name(false)?;
                 parser.expect_keyword(Keyword::TO)?;
                 let new_name = parser.parse_object_name(false)?;
 
-                Ok(RenameObjectDef { old_name, new_name })
+                Ok(RenameTable { old_name, new_name })
             })?;
             Ok(Statement::RenameTable(rename_object_defs))
         } else {

tests/sqlparser_common.rs

@@ -4028,19 +4028,17 @@ fn parse_alter_table() {
 
 #[test]
 fn parse_rename_table() {
-    let dialects = all_dialects_where(|d| d.supports_rename_table());
-
-    match dialects.verified_stmt("RENAME TABLE `test`.`test1` TO `test_db`.`test2`") {
+    match verified_stmt("RENAME TABLE test.test1 TO test_db.test2") {
         Statement::RenameTable(rename_object_defs) => {
             assert_eq!(
-                vec![RenameObjectDef {
+                vec![RenameTable {
                     old_name: ObjectName(vec![
-                        Ident::with_quote('`', "test".to_string()),
-                        Ident::with_quote('`', "test1".to_string()),
+                        Ident::new("test".to_string()),
+                        Ident::new("test1".to_string()),
                     ]),
                     new_name: ObjectName(vec![
-                        Ident::with_quote('`', "test_db".to_string()),
-                        Ident::with_quote('`', "test2".to_string()),
+                        Ident::new("test_db".to_string()),
+                        Ident::new("test2".to_string()),
                     ]),
                 }],
                 rename_object_defs
@@ -4049,21 +4047,21 @@ fn parse_rename_table() {
         _ => unreachable!(),
     };
 
-    match dialects.verified_stmt(
+    match verified_stmt(
         "RENAME TABLE old_table1 TO new_table1, old_table2 TO new_table2, old_table3 TO new_table3",
     ) {
         Statement::RenameTable(rename_object_defs) => {
             assert_eq!(
                 vec![
-                    RenameObjectDef {
+                    RenameTable {
                         old_name: ObjectName(vec![Ident::new("old_table1".to_string())]),
                         new_name: ObjectName(vec![Ident::new("new_table1".to_string())]),
                     },
-                    RenameObjectDef {
+                    RenameTable {
                         old_name: ObjectName(vec![Ident::new("old_table2".to_string())]),
                         new_name: ObjectName(vec![Ident::new("new_table2".to_string())]),
                     },
-                    RenameObjectDef {
+                    RenameTable {
                         old_name: ObjectName(vec![Ident::new("old_table3".to_string())]),
                         new_name: ObjectName(vec![Ident::new("new_table3".to_string())]),
                     }
@@ -4075,31 +4073,16 @@ fn parse_rename_table() {
     };
 
     assert_eq!(
-        dialects
-            .parse_sql_statements("RENAME TABLE `old_table` TO new_table a")
-            .unwrap_err(),
+        parse_sql_statements("RENAME TABLE old_table TO new_table a").unwrap_err(),
         ParserError::ParserError("Expected: end of statement, found: a".to_string())
     );
 
     assert_eq!(
-        dialects
-            .parse_sql_statements("RENAME TABLE1 `old_table` TO new_table a")
-            .unwrap_err(),
+        parse_sql_statements("RENAME TABLE1 old_table TO new_table a").unwrap_err(),
         ParserError::ParserError(
             "Expected: KEYWORD `TABLE` after RENAME, found: TABLE1".to_string()
         )
     );
-
-    let dialects = all_dialects_where(|d| !d.supports_rename_table());
-
-    assert_eq!(
-        dialects
-            .parse_sql_statements("RENAME TABLE `old_table` TO new_table")
-            .unwrap_err(),
-        ParserError::ParserError(
-            "Expected: KEYWORD `TABLE` after RENAME, found: TABLE".to_string()
-        )
-    );
 }
 
 #[test]