-
Notifications
You must be signed in to change notification settings - Fork 26
Closed
Description
I have uncovered a couple issues with template/Properties/Default.rd.xml:
- CB-14224 - running
coho audit-license-headers -r windowsgives a message thattemplate/Properties/Default.rd.xmlis missing the license header - CB-14225 - misspelling in sample Namespace serialize attribute name
along with an additional issue that seems to be unsolved:
- CB-13834 - problem building with build with params
--release --bundle --archs="x64 x86 arm"on AppVeyor CI
I start to wonder if we should even keep template/Properties/Default.rd.xml in future releases. The following observations indicate to me that xxxx is only needed for projects using C# plugins:
- If I would try generating both a JavaScript UWP project and a C# UWP project then VS 2017 would only add
Properties/Default.rd.xmlin case of C#. - Microsoft / Windows-universal-samples keeps its sample
Default.rd.xmlin acsdirectory (Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml
I can think of the following possible alternatives:
- add license text and fix Namespace Serialize attribute name as proposed in CB-14224 Default.rd.xml header fixes cordova-windows#284, CB-14224 Default.rd.xml updates (6.0.x patch) cordova-windows#285, and CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml cordova-windows#286
- configure Apache RAT to skip
template/Properties/Default.rd.xmland fix sample Namespace Serialize attribute (CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml cordova-windows#286) (I haven't tried this yet) - remove
template/Properties/Default.rd.xmlin upcoming major release - make it optional to include
Properties/Default.rd.xmlin generated project - handle
Properties/Default.rd.xmlin a plugin (if possible)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels