interconnect: increase UDP unack queue size and fix mem size unit #1520
Closed
yjhjstz wants to merge 1 commit intoapache:mainfrom
Closed
interconnect: increase UDP unack queue size and fix mem size unit #1520yjhjstz wants to merge 1 commit intoapache:mainfrom
yjhjstz wants to merge 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the UDP interconnect performance by increasing the maximum queue size and fixing a critical unit conversion bug in memory calculation.
- Doubles MAX_QUEUE_SIZE from 64 to 128 to support larger unacknowledged packet windows
- Fixes memory size calculation by properly converting
gp_interconnect_mem_sizefrom MB to bytes (multiplying by 1024 * 1024)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leborchuk
reviewed
Jan 5, 2026
yjhjstz
force-pushed
the
fix_ic
branch
2 times, most recently
from
ad59772 to
7fc6319
Compare
leborchuk
approved these changes
Jan 8, 2026
reshke
approved these changes
Jan 15, 2026
yjhjstz
force-pushed
the
fix_ic
branch
3 times, most recently
from
39d3b15 to
ff24ff7
Compare
my-ship-it
reviewed
Jan 23, 2026
…dling Fix calculation of per-queue capacity in SetupUDPIFCInterconnect by properly converting gp_interconnect_mem_size from MB to bytes. Without this conversion, the derived send queue depth could be severely underestimated, leading to suboptimal throughput.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase MAX_QUEUE_SIZE from 64 to 128 to allow a larger unacknowledged packet window in UDP interconnect, reducing stalls under high-latency or bursty workloads.
Fix calculation of per-queue capacity in SetupUDPIFCInterconnect by properly converting gp_interconnect_mem_size from MB to bytes. Without this conversion, the derived send queue depth could be severely underestimated, leading to suboptimal throughput.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions