Skip to content

Commit 33f99fd

Browse files
andreasfertigandreasfertig
committed
Clang 19 updated tests and switched.
1 parent 66cf8b2 commit 33f99fd

39 files changed

+261
-200
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616
env:
1717
CMAKE_VERSION: 3.29.0
1818
NINJA_VERSION: 1.11.1
19-
LLVM_VERSION: 18.1.0
19+
LLVM_VERSION: 19.1.0
2020
NINJA_STATUS: "[%f/%t %o/sec] "
2121

2222
jobs:
@@ -32,7 +32,7 @@ jobs:
3232
name: "Linux Clang - Format check",
3333
os: ubuntu-20.04,
3434
build_type: Release,
35-
cformat_name: 'clang-format-18'
35+
cformat_name: 'clang-format-19'
3636
}
3737

3838
steps:
@@ -45,7 +45,7 @@ jobs:
4545
run: |
4646
wget https://apt.llvm.org/llvm.sh
4747
chmod +x llvm.sh
48-
sudo ./llvm.sh 18
48+
sudo ./llvm.sh 19
4949
sudo apt-get install ${{ matrix.config.cformat_name }}
5050
5151
- name: clang-format check
@@ -68,11 +68,11 @@ jobs:
6868
config:
6969
# AppleClang
7070
- {
71-
name: "Clang 18 / LLVM 18 @ macOS Release",
71+
name: "Clang 19 / LLVM 19 @ macOS Release",
7272
os: macos-14,
7373
build_type: Release,
7474
cxx: "clang++",
75-
llvm_version: "18.1.0",
75+
llvm_version: "19.1.0",
7676
llvm_config: "llvm-config",
7777
coverage: "No",
7878
static: "No",
@@ -87,11 +87,11 @@ jobs:
8787

8888
# AppleClang
8989
- {
90-
name: "Clang 18 / LLVM 18 @ macOS Debug",
90+
name: "Clang 19 / LLVM 19 @ macOS Debug",
9191
os: macos-14,
9292
build_type: Release,
9393
cxx: "clang++",
94-
llvm_version: "18.1.0",
94+
llvm_version: "19.1.0",
9595
llvm_config: "llvm-config",
9696
coverage: "No",
9797
static: "No",
@@ -106,11 +106,11 @@ jobs:
106106

107107
# AppleClang
108108
- {
109-
name: "Clang 18 / LLVM 18 @ macOS Coverage & Debug",
109+
name: "Clang 19 / LLVM 19 @ macOS Coverage & Debug",
110110
os: macos-14,
111111
build_type: Release,
112112
cxx: "clang++",
113-
llvm_version: "18.1.0",
113+
llvm_version: "19.1.0",
114114
llvm_config: "llvm-config",
115115
coverage: "Yes",
116116
static: "No",
@@ -124,11 +124,11 @@ jobs:
124124

125125
# # MSVC 2019
126126
# - {
127-
# name: "MSVC 2022 / LLVM 18 @ Windows Release",
127+
# name: "MSVC 2022 / LLVM 19 @ Windows Release",
128128
# os: windows-2022,
129129
# build_type: Release,
130130
# cxx: "cl",
131-
# llvm_version: "18.1.0",
131+
# llvm_version: "19.1.0",
132132
# llvm_config: "current/bin/llvm-config.exe",
133133
# static: "Yes",
134134
# debug: "No",
@@ -143,11 +143,11 @@ jobs:
143143

144144
# # MSVC 2019
145145
# - {
146-
# name: "MSVC 2022 / LLVM 18 @ Windows Debug",
146+
# name: "MSVC 2022 / LLVM 19 @ Windows Debug",
147147
# os: windows-2022,
148148
# build_type: Release,
149149
# cxx: "cl",
150-
# llvm_version: "18.1.0",
150+
# llvm_version: "19.1.0",
151151
# llvm_config: "current/bin/llvm-config.exe",
152152
# static: "Yes",
153153
# debug: "Yes",
@@ -161,11 +161,11 @@ jobs:
161161

162162
# # MSVC 2019
163163
# - {
164-
# name: "MSVC 2022 / LLVM 18 @ Windows Code Coverage & Debug",
164+
# name: "MSVC 2022 / LLVM 19 @ Windows Code Coverage & Debug",
165165
# os: windows-2022,
166166
# build_type: Release,
167167
# cxx: "clang-cl.exe",
168-
# llvm_version: "18.1.0",
168+
# llvm_version: "19.1.0",
169169
# llvm_config: "current/bin/llvm-config.exe",
170170
# coverage: "Yes",
171171
# static: "Yes",
@@ -460,13 +460,13 @@ jobs:
460460
- amd64
461461

462462
config:
463-
# GCC 13 / LLVM 18
463+
# GCC 13 / LLVM 19
464464
- {
465-
name: "GCC 13 / LLVM 18 @ Ubuntu Release",
465+
name: "GCC 13 / LLVM 19 @ Ubuntu Release",
466466
build_type: Release,
467467
cxx: "g++-13",
468-
llvm_version: "18.1.0",
469-
llvm_config: "/usr/bin/llvm-config-18",
468+
llvm_version: "19.1.0",
469+
llvm_config: "/usr/bin/llvm-config-19",
470470
coverage: "No",
471471
static: "Yes",
472472
debug: "No",
@@ -479,13 +479,13 @@ jobs:
479479
docs: "Yes",
480480
}
481481

482-
# GCC 13 / LLVM 18
482+
# GCC 13 / LLVM 19
483483
- {
484-
name: "GCC 13 / LLVM 18 @ Ubuntu Code Coverage & Debug",
484+
name: "GCC 13 / LLVM 19 @ Ubuntu Code Coverage & Debug",
485485
build_type: Release,
486486
cxx: "g++-13",
487-
llvm_version: "18.1.0",
488-
llvm_config: "/usr/bin/llvm-config-18",
487+
llvm_version: "19.1.0",
488+
llvm_config: "/usr/bin/llvm-config-19",
489489
coverage: "Yes",
490490
static: "No",
491491
debug: "Yes",
@@ -496,13 +496,13 @@ jobs:
496496
archive_name: "insights-ubuntu",
497497
}
498498

499-
# GCC 13 / LLVM 18
499+
# GCC 13 / LLVM 19
500500
- {
501-
name: "GCC 13 / LLVM 18 @ Ubuntu Code Coverage (libc++)",
501+
name: "GCC 13 / LLVM 19 @ Ubuntu Code Coverage (libc++)",
502502
build_type: Release,
503503
cxx: "g++-13",
504-
llvm_version: "18.1.0",
505-
llvm_config: "/usr/bin/llvm-config-18",
504+
llvm_version: "19.1.0",
505+
llvm_config: "/usr/bin/llvm-config-19",
506506
coverage: "Yes",
507507
static: "No",
508508
debug: "Yes",
@@ -649,13 +649,13 @@ jobs:
649649
- amd64
650650

651651
config:
652-
# GCC 13 / LLVM 18
652+
# GCC 13 / LLVM 19
653653
- {
654-
name: "GCC 13 / LLVM 18 @ Ubuntu Release",
654+
name: "GCC 13 / LLVM 19 @ Ubuntu Release",
655655
build_type: Release,
656656
cxx: "g++-13",
657-
llvm_version: "18.1.0",
658-
llvm_config: "/usr/bin/llvm-config-18",
657+
llvm_version: "19.1.0",
658+
llvm_config: "/usr/bin/llvm-config-19",
659659
coverage: "No",
660660
static: "Yes",
661661
debug: "No",

‎CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ option(INSIGHTS_STATIC "Use static linking" Off)
3232

3333
set(INSIGHTS_LLVM_CONFIG "llvm-config" CACHE STRING "LLVM config executable to use")
3434

35-
set(INSIGHTS_MIN_LLVM_MAJOR_VERSION 18)
35+
set(INSIGHTS_MIN_LLVM_MAJOR_VERSION 19)
3636
set(INSIGHTS_MIN_LLVM_VERSION ${INSIGHTS_MIN_LLVM_MAJOR_VERSION}.0)
3737

3838
if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)

‎scripts/prepare-release.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def main():
1616

1717
oldClangStable = '18'
1818
newClangStable = '19'
19-
newInsightsVersion = f'{newClangStable}.0'
19+
newInsightsVersion = f'{newClangStable}.1'
2020
oldInsightsVersion = re.search(r'INSIGHTS_VERSION\s+"(.*?)"', versionH, re.DOTALL | re.MULTILINE).group(1)
2121

2222

‎tests/DependentScopeDeclRefExprTest.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ struct A;
5050
template <typename T>
5151
void test() {
5252
A<T>::foo;
53-
A<T>::template foo;
53+
//A<T>::template foo; // Invalid since Clang 19
5454
A<T>::template foo<>;
5555
A<T>::template foo<T>;
5656
}

‎tests/DependentScopeDeclRefExprTest.expect‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ namespace DependentScopeDeclRefExpr
116116
void test()
117117
{
118118
A<T>::foo;
119-
A<T>::template foo;
120119
A<T>::template foo<>;
121120
A<T>::template foo<T>;
122121
}

‎tests/EduCfrontTest17.cerr‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
| ;
55
.tmp.cpp:9:1: warning: typedef requires a name [-Wmissing-declarations]
66
9 | typedef struct Foo
7-
| ^~~~~~~
7+
| ^~~~~~~~~~~~~~~~~~
88
.tmp.cpp:12:3: warning: declaration does not declare anything [-Wmissing-declarations]
99
12 | } Foo;
1010
| ^~~

‎tests/EduCfrontTest21.cerr‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
| ;
55
.tmp.cpp:11:1: warning: typedef requires a name [-Wmissing-declarations]
66
11 | typedef struct Foo
7-
| ^~~~~~~
7+
| ^~~~~~~~~~~~~~~~~~
88
.tmp.cpp:15:3: warning: declaration does not declare anything [-Wmissing-declarations]
99
15 | } Foo;
1010
| ^~~

‎tests/EduCoroutineAllocFailureTest.expect‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ void __fun_intDestroy(__fun_intFrame * __f)
250250
__f->~__fun_intFrame();
251251
/* Deallocating the coroutine frame */
252252
/* Note: The actual argument to delete is __builtin_coro_frame with the promise as parameter */
253-
operator delete(static_cast<void *>(__f));
253+
operator delete(static_cast<void *>(__f), sizeof(__fun_intFrame));
254254
}
255255

256256
#endif

‎tests/EduCoroutineBinaryExprTest.expect‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ void __seqDestroy(__seqFrame * __f)
232232
__f->~__seqFrame();
233233
/* Deallocating the coroutine frame */
234234
/* Note: The actual argument to delete is __builtin_coro_frame with the promise as parameter */
235-
operator delete(static_cast<void *>(__f));
235+
operator delete(static_cast<void *>(__f), sizeof(__seqFrame));
236236
}
237237

238238

‎tests/EduCoroutineCaptureConstTest.expect‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ void __seqDestroy(__seqFrame * __f)
178178
__f->~__seqFrame();
179179
/* Deallocating the coroutine frame */
180180
/* Note: The actual argument to delete is __builtin_coro_frame with the promise as parameter */
181-
operator delete(static_cast<void *>(__f));
181+
operator delete(static_cast<void *>(__f), sizeof(__seqFrame));
182182
}
183183

184184

0 commit comments

Comments
 (0)