From b063ac938bece0fd21de6a9019252c4b4b30645f Mon Sep 17 00:00:00 2001 From: Mohamed Elgaar Date: Mon, 10 Nov 2025 01:08:22 -0500 Subject: [PATCH] Fix comment clarity in `maybe_evaluate` function in `grpo_fast.py` to accurately reflect timeout logic. --- open_instruct/grpo_fast.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/open_instruct/grpo_fast.py b/open_instruct/grpo_fast.py index cac12986e..d96e51b0c 100644 --- a/open_instruct/grpo_fast.py +++ b/open_instruct/grpo_fast.py @@ -2650,7 +2650,7 @@ def maybe_evaluate( ): """Optionally evaluate the model.""" try: - # timeout 0.01 if this is the last training step or we're not evaluating + # timeout 0.01 if this is not the last training step or we're not evaluating # otherwise, wait to get the last evaluation generations (long timeout just in case) timeout = 0.01 if (training_step < args.num_training_steps or args.local_eval_every < 0) else 100