Skip to content

Commit b504334

Browse files
committed
fix eval_on_step0
1 parent d754a3c commit b504334

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

open_instruct/grpo_fast.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3047,9 +3047,14 @@ def health_check_fn():
30473047
) = load_data_from_packing_thread(packed_sequences_Q, num_total_tokens, stop_event, health_check_fn)
30483048

30493049
if (
3050-
training_step % args.local_eval_every == 0
3051-
and eval_dataset is not None
3052-
and (args.eval_on_step_0 or training_step > 1)
3050+
eval_dataset is not None
3051+
and (
3052+
(args.eval_on_step_0 and training_step == resume_training_step)
3053+
or (
3054+
training_step % args.local_eval_every == 0
3055+
and training_step > 1
3056+
)
3057+
)
30533058
):
30543059
for eval_index, eval_example in enumerate(eval_dataset):
30553060
add_prompt_to_generator(

0 commit comments

Comments
 (0)