Fix non-deterministic annotation generation by using declaredAnnotationValues

The xprocessing library's XAnnotation.annotationValues property exhibits
non-deterministic behavior in KSP, sometimes returning annotation values
with defaults and sometimes returning an empty list. This caused tests
to fail randomly depending on which values were returned during processing.

Switched to using declaredAnnotationValues instead, which consistently
returns only explicitly declared values (excluding defaults). This approach
mirrors Room's implementation in JavaPoetExt.kt.

This fix eliminates the flakiness where @deprecated would sometimes be
generated as @deprecated and sometimes as @deprecated(since = "", forRemoval = false).

Author: martinbirn

epoxy-processor/src/main/java/com/airbnb/epoxy/processor/XProcessingUtils.kt

@@ -174,7 +174,14 @@ fun XAnnotation.toAnnotationSpec(memoizer: Memoizer): AnnotationSpec {
         return addMember(memberName, "\$L", value)
     }
     return AnnotationSpec.builder(ClassName.get(packageName, name)).apply {
-        annotationValues.forEach { annotationValue ->
+        // Use declaredAnnotationValues instead of annotationValues to exclude default values.
+        // This ensures consistent behavior across KSP runs, as annotationValues has been observed
+        // to non-deterministically return different results in KSP (sometimes including defaults,
+        // sometimes not).
+        //
+        // This approach mirrors Room's implementation in JavaPoetExt.kt:
+        // @see androidx.room.compiler.processing.toAnnotationSpec
+        declaredAnnotationValues.forEach { annotationValue ->
             addMemberForValue(annotationValue.name, annotationValue.value, memoizer)
         }
     }.build()

epoxy-processortest/src/test/resources/ModelWithAnnotation_.java

@@ -12,10 +12,7 @@
 /**
  * Generated file. Do not modify!
  */
-@Deprecated(
-    since = "",
-    forRemoval = false
-)
+@Deprecated
 public class ModelWithAnnotation_ extends ModelWithAnnotation implements GeneratedModel<Object>, ModelWithAnnotationBuilder {
   private OnModelBoundListener<ModelWithAnnotation_, Object> onModelBoundListener_epoxyGeneratedModel;
 

epoxy-processortest/src/test/resources/ViewProcessorTest/annotationsAreCopied/SourceViewModel_.java

@@ -14,10 +14,7 @@
 /**
  * Generated file. Do not modify!
  */
-@Deprecated(
-    since = "",
-    forRemoval = false
-)
+@Deprecated
 public class SourceViewModel_ extends EpoxyModel<SourceView> implements GeneratedModel<SourceView>, SourceViewModelBuilder {
   private OnModelBoundListener<SourceViewModel_, SourceView> onModelBoundListener_epoxyGeneratedModel;
 

epoxy-processortest/src/test/resources/ViewProcessorTest/annotationsAreCopied/ksp/SourceViewModel_.java

@@ -10,16 +10,12 @@
 import java.lang.String;
 import java.lang.UnsupportedOperationException;
 import kotlin.Deprecated;
-import kotlin.DeprecationLevel;
-import kotlin.ReplaceWith;
 
 /**
  * Generated file. Do not modify!
  */
 @Deprecated(
-    message = "some message",
-    replaceWith = @ReplaceWith(expression = "", imports = {}),
-    level = DeprecationLevel.WARNING
+    message = "some message"
 )
 public class SourceViewModel_ extends EpoxyModel<SourceView> implements GeneratedModel<SourceView>, SourceViewModelBuilder {
   private OnModelBoundListener<SourceViewModel_, SourceView> onModelBoundListener_epoxyGeneratedModel;

epoxy-processortest/src/test/resources/ViewProcessorTest/inheritingAttributesWorksCorrectly/SourceViewModelBuilder.java

@@ -18,7 +18,7 @@ SourceViewModelBuilder onVisibilityStateChanged(
   SourceViewModelBuilder onVisibilityChanged(
       OnModelVisibilityChangedListener<SourceViewModel_, SourceView> listener);
 
-  SourceViewModelBuilder sectionId(@Nullable("") String sectionId);
+  SourceViewModelBuilder sectionId(@Nullable String sectionId);
 
   SourceViewModelBuilder baseViewProp(int baseViewProp);
 

epoxy-processortest/src/test/resources/ViewProcessorTest/inheritingAttributesWorksCorrectly/SourceViewModel_.java

@@ -23,7 +23,7 @@ public class SourceViewModel_ extends AirEpoxyModel<SourceView> implements Gener
 
   private OnModelVisibilityChangedListener<SourceViewModel_, SourceView> onModelVisibilityChangedListener_epoxyGeneratedModel;
 
-  @Nullable("")
+  @Nullable
   private String sectionId_String = (String) null;
 
   private int baseViewProp_Int = 0;
@@ -180,13 +180,13 @@ public SourceViewModel_ onVisibilityChanged(
    *
    * @see SourceView#setSectionId(String)
    */
-  public SourceViewModel_ sectionId(@Nullable("") String sectionId) {
+  public SourceViewModel_ sectionId(@Nullable String sectionId) {
     onMutation();
     this.sectionId_String = sectionId;
     return this;
   }
 
-  @Nullable("")
+  @Nullable
   public String sectionId() {
     return sectionId_String;
   }

epoxy-processortest/src/test/resources/ViewProcessorTest/inheritingAttributesWorksCorrectlyJavaClassPath/SourceViewModelBuilder.java

@@ -17,7 +17,7 @@ SourceViewModelBuilder onVisibilityStateChanged(
   SourceViewModelBuilder onVisibilityChanged(
       OnModelVisibilityChangedListener<SourceViewModel_, SourceView> listener);
 
-  SourceViewModelBuilder sectionId(@Nullable("") String sectionId);
+  SourceViewModelBuilder sectionId(@Nullable String sectionId);
 
   SourceViewModelBuilder processorTest2ValueProtected(int processorTest2ValueProtected);
 

epoxy-processortest/src/test/resources/ViewProcessorTest/inheritingAttributesWorksCorrectlyJavaClassPath/SourceViewModel_.java

@@ -23,7 +23,7 @@ public class SourceViewModel_ extends ProcessorTest2Model<SourceView> implements
 
   private OnModelVisibilityChangedListener<SourceViewModel_, SourceView> onModelVisibilityChangedListener_epoxyGeneratedModel;
 
-  @Nullable("")
+  @Nullable
   private String sectionId_String = (String) null;
 
   public SourceViewModel_() {
@@ -166,13 +166,13 @@ public SourceViewModel_ onVisibilityChanged(
    *
    * @see SourceView#setSectionId(String)
    */
-  public SourceViewModel_ sectionId(@Nullable("") String sectionId) {
+  public SourceViewModel_ sectionId(@Nullable String sectionId) {
     onMutation();
     this.sectionId_String = sectionId;
     return this;
   }
 
-  @Nullable("")
+  @Nullable
   public String sectionId() {
     return sectionId_String;
   }

epoxy-processortest/src/test/resources/ViewProcessorTest/testManyTypes/TestManyTypesViewModelBuilder.java

@@ -7,7 +7,6 @@
 import androidx.annotation.StringRes;
 import java.lang.Boolean;
 import java.lang.CharSequence;
-import java.lang.Exception;
 import java.lang.Integer;
 import java.lang.Number;
 import java.lang.Object;
@@ -33,25 +32,23 @@ TestManyTypesViewModelBuilder onVisibilityChanged(
 
   TestManyTypesViewModelBuilder myProperty(int myProperty);
 
-  TestManyTypesViewModelBuilder myNullableProperty(@Nullable("") Integer myNullableProperty);
+  TestManyTypesViewModelBuilder myNullableProperty(@Nullable Integer myNullableProperty);
 
   TestManyTypesViewModelBuilder delegatedProperty(int delegatedProperty);
 
   TestManyTypesViewModelBuilder enabled(boolean enabled);
 
-  TestManyTypesViewModelBuilder stringValue(
-      @NotNull(value = "", exception = Exception.class) String stringValue);
+  TestManyTypesViewModelBuilder stringValue(@NotNull String stringValue);
 
   TestManyTypesViewModelBuilder functionType(
-      @NotNull(value = "", exception = Exception.class) Function2<? super String, ? super String, Integer> functionType);
+      @NotNull Function2<? super String, ? super String, Integer> functionType);
 
-  TestManyTypesViewModelBuilder listOfDataClass(
-      @NotNull(value = "", exception = Exception.class) List<SomeDataClass> listOfDataClass);
+  TestManyTypesViewModelBuilder listOfDataClass(@NotNull List<SomeDataClass> listOfDataClass);
 
   TestManyTypesViewModelBuilder listOfEnumClass(
-      @NotNull(value = "", exception = Exception.class) List<? extends SomeEnumClass> listOfEnumClass);
+      @NotNull List<? extends SomeEnumClass> listOfEnumClass);
 
-  TestManyTypesViewModelBuilder nullableStringValue(@Nullable("") String nullableStringValue);
+  TestManyTypesViewModelBuilder nullableStringValue(@Nullable String nullableStringValue);
 
   TestManyTypesViewModelBuilder intValue(int intValue);
 
@@ -72,22 +69,21 @@ TestManyTypesViewModelBuilder intWithMultipleAnnotations(
 
   TestManyTypesViewModelBuilder boolValue(boolean boolValue);
 
-  TestManyTypesViewModelBuilder models(
-      @NotNull(value = "", exception = Exception.class) List<? extends EpoxyModel<?>> models);
+  TestManyTypesViewModelBuilder models(@NotNull List<? extends EpoxyModel<?>> models);
 
-  TestManyTypesViewModelBuilder booleanValue(@Nullable("") Boolean booleanValue);
+  TestManyTypesViewModelBuilder booleanValue(@Nullable Boolean booleanValue);
 
-  TestManyTypesViewModelBuilder arrayValue(@Nullable("") String[] arrayValue);
+  TestManyTypesViewModelBuilder arrayValue(@Nullable String[] arrayValue);
 
-  TestManyTypesViewModelBuilder listValue(@Nullable("") List<String> listValue);
+  TestManyTypesViewModelBuilder listValue(@Nullable List<String> listValue);
 
   TestManyTypesViewModelBuilder clickListener(
-      @Nullable("") final OnModelClickListener<TestManyTypesViewModel_, TestManyTypesView> clickListener);
+      @Nullable final OnModelClickListener<TestManyTypesViewModel_, TestManyTypesView> clickListener);
 
-  TestManyTypesViewModelBuilder clickListener(@Nullable("") View.OnClickListener clickListener);
+  TestManyTypesViewModelBuilder clickListener(@Nullable View.OnClickListener clickListener);
 
   TestManyTypesViewModelBuilder customClickListener(
-      @Nullable("") CustomClickListenerSubclass customClickListener);
+      @Nullable CustomClickListenerSubclass customClickListener);
 
   TestManyTypesViewModelBuilder title(@androidx.annotation.Nullable CharSequence title);