Fix: space as special char (closes #7) (#10)

* Fix: add space as special char

* Test: update tests for new fix

Author: aichbauer

src/helpers/check-special-chars-and-empty.js

@@ -10,6 +10,7 @@ export const checkSpecialCharsAndEmpty = (value) => {
     || thisValue.includes('\'')
     || thisValue.includes('`')
     || thisValue.includes('´')
+    || thisValue.includes(' ')
     || thisValue.length === 0;
 
   return hasSpecialChars;

test/fixtures/data.js

@@ -15,10 +15,10 @@ const dataArrayWithNullAndUndefined = [
 ];
 
 const dataArrayWithZero = [
-	[0, 'Mark', 'Otto', '@mdo'],
-	[1, 'Jacob', 'Thornton', '@fat'],
-	[2, 'Larry', 'the Bird', '@twitter'],
-]
+  [0, 'Mark', 'Otto', '@mdo'],
+  [1, 'Jacob', 'Thornton', '@fat'],
+  [2, 'Larry', 'the Bird', '@twitter'],
+];
 
 const data = [
   {

test/fixtures/expected-results.js

@@ -1,25 +1,25 @@
-export const expectedResultArrayNoHeaderNoOptions = '1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,the Bird,@twitter\n';
+export const expectedResultArrayNoHeaderNoOptions = '1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
 
-export const expectedResultObjectNoOptions = 'number,first,last,handle\n1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,the Bird,@twitter\n';
+export const expectedResultObjectNoOptions = 'number,first,last,handle\n1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
 
-export const expectedResultObjectOnlyHeader = 'Number,First,Last,Handle\n1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,the Bird,@twitter\n';
+export const expectedResultObjectOnlyHeader = 'Number,First,Last,Handle\n1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
 
-export const expectedResultObjectNullAndUndefined = 'Number,First,Last,Handle\n1,Mark,"",@mdo\n2,Jacob,Thornton,""\n3,Larry,the Bird,@twitter\n';
+export const expectedResultObjectNullAndUndefined = 'Number,First,Last,Handle\n1,Mark,"",@mdo\n2,Jacob,Thornton,""\n3,Larry,"the Bird",@twitter\n';
 
-export const expectedResultArrayNullAndUndefined = 'number,first,last,handle\n1,Mark,"",@mdo\n2,Jacob,Thornton,""\n3,Larry,the Bird,@twitter\n';
+export const expectedResultArrayNullAndUndefined = 'number,first,last,handle\n1,Mark,"",@mdo\n2,Jacob,Thornton,""\n3,Larry,"the Bird",@twitter\n';
 
-export const expectedResultArrayZero = 'number,first,last,handle\n0,Mark,Otto,@mdo\n1,Jacob,Thornton,@fat\n2,Larry,the Bird,@twitter\n';
+export const expectedResultArrayZero = 'number,first,last,handle\n0,Mark,Otto,@mdo\n1,Jacob,Thornton,@fat\n2,Larry,"the Bird",@twitter\n';
 
-export const expectedResultObjectHeaderSeparatorSemicolon = 'Number;First;Last;Handle\n1;Mark;Otto;@mdo\n2;Jacob;Thornton;@fat\n3;Larry;the Bird;@twitter\n';
+export const expectedResultObjectHeaderSeparatorSemicolon = 'Number;First;Last;Handle\n1;Mark;Otto;@mdo\n2;Jacob;Thornton;@fat\n3;Larry;"the Bird";@twitter\n';
 
-export const expectedResultObjecOnlySeparatorTab = 'number\tfirst\tlast\thandle\n1\tMark\tOtto\t@mdo\n2\tJacob\tThornton\t@fat\n3\tLarry\tthe Bird\t@twitter\n';
+export const expectedResultObjecOnlySeparatorTab = 'number\tfirst\tlast\thandle\n1\tMark\tOtto\t@mdo\n2\tJacob\tThornton\t@fat\n3\tLarry\t"the Bird"\t@twitter\n';
+
+export const expectedResultArrayHeaderWithSpaces = '"number number",first,last,handle\n1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
 
 export const expectedResultArrayWithHeaderNoOptions = expectedResultObjectNoOptions;
 
 export const expectedResultArrayOnlyHeader = expectedResultObjectOnlyHeader;
 
-export const expectedResultArrayHeaderSeparatorSemicolon =
-  expectedResultObjectHeaderSeparatorSemicolon;
+export const expectedResultArrayHeaderSeparatorSemicolon = expectedResultObjectHeaderSeparatorSemicolon; // eslint-disable-line
 
 export const expectedResultArrayOnlySeparatorTab = expectedResultObjecOnlySeparatorTab;
-

test/fixtures/options.js

@@ -3,6 +3,11 @@ export const optionsHeaderSeparatorDefault = {
   separator: ',',
 };
 
+export const optionsHeaderWithSpacesSeparatorDefault = {
+  header: ['number number', 'first', 'last', 'handle'],
+  separator: ',',
+};
+
 export const optionsHeaderSeperatorSemicolon = {
   header: ['Number', 'First', 'Last', 'Handle'],
   separator: ';',

test/index.spec.js

@@ -8,14 +8,22 @@ import {
 import {
   expectedResultArrayNoHeaderNoOptions,
   expectedResultObjectNoOptions,
+  expectedResultArrayHeaderWithSpaces,gco 
 } from './fixtures/expected-results';
+import { optionsHeaderWithSpacesSeparatorDefault } from './fixtures/options';
 
 test('convertArrayToCsv | array of arrays | with no header and no options', () => {
   const result = convertArrayToCSV(dataArrayWithoutHeader);
 
   expect(result).toBe(expectedResultArrayNoHeaderNoOptions);
 });
 
+test('convertArrayToCsv | array of arrays | with header with spaces and no options', () => {
+  const result = convertArrayToCSV(dataArrayWithoutHeader, optionsHeaderWithSpacesSeparatorDefault);
+
+  expect(result).toBe(expectedResultArrayHeaderWithSpaces);
+});
+
 test('convertArrayToCsv | array of objects | with no options', () => {
   const result = convertArrayToCSV(dataObject);