Fix: replace every double quote (#15)

* Fix: replace every doublequote

* Test: update fixtures to test multiple occurances

Author: aichbauer

src/helpers/append-element.js

@@ -6,7 +6,7 @@ const separatorOrLineBreak = (length, elementIdx, separator) => (
 );
 
 const escapeDoubleQuotesInsideElement = (element) => {
-  const thisElement = element.replace('"', '""');
+  const thisElement = element.replace(/"/g, '""');
 
   return thisElement;
 };

src/modules/convert-array-of-arrays-to-csv.js

@@ -1,5 +1,3 @@
-// import { checkSpecialCharsAndEmpty } from '../helpers/check-special-chars-and-empty';
-
 import { appendElement } from '../helpers/append-element';
 
 export const convertArrayOfArraysToCSV = (data, { header, separator }) => {

test/fixtures/data.js

@@ -9,7 +9,7 @@ const dataArray = [
 ];
 
 const dataArrayWithDoubleQuotes = [
-  [1, 'Mark', 'Ot"to', '@mdo'],
+  [1, 'Mark', 'Ot"t"o', '@mdo'],
   [2, 'Jacob', 'Thornton', '@fat'],
   [3, 'Larry', 'the Bird', '@twitter'],
 ];
@@ -51,7 +51,7 @@ const dataObjectWithDoubleQuotes = [
   {
     number: 1,
     first: 'Mark',
-    last: 'Ot"to',
+    last: 'Ot"t"o',
     handle: '@mdo',
   },
   {

test/fixtures/expected-results.js

@@ -16,7 +16,7 @@ export const expectedResultObjecOnlySeparatorTab = 'number\tfirst\tlast\thandle\
 
 export const expectedResultArrayHeaderWithSpaces = '"number number",first,last,handle\n1,Mark,Otto,@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
 
-export const expectedResultArrayWithDoubleQoutesInsideElement = '1,Mark,"Ot""to",@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
+export const expectedResultArrayWithDoubleQoutesInsideElement = '1,Mark,"Ot""t""o",@mdo\n2,Jacob,Thornton,@fat\n3,Larry,"the Bird",@twitter\n';
 
 export const expectedResultArrayWithHeaderNoOptions = expectedResultObjectNoOptions;