Restrict definition of ui5 xml control slightly

knewbury01 · knewbury01 · commit f6b759dfe6d1 · 2025-12-02T17:05:03.000-05:00
diff --git a/javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5View.qll b/javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5View.qll
@@ -684,7 +684,7 @@ class XmlView extends UI5View instanceof XmlFile {
 }
 
 private newtype TUI5Control =
-  TXmlControl(XmlElement control) or
+  TXmlControl(XmlElement control) { control.getFile().getName().matches("%.view.xml") } or
   TJsonControl(JsonObject control) {
     exists(JsonView view | control.getParent() = view.getRoot().getPropValue("content"))
   } or

Original file line number	Diff line number	Diff line change
`@@ -684,7 +684,7 @@ class XmlView extends UI5View instanceof XmlFile {`
`684`	`684`	`}`
`685`	`685`
`686`	`686`	`private newtype TUI5Control =`
`687`		`- TXmlControl(XmlElement control) or`
	`687`	`+ TXmlControl(XmlElement control) { control.getFile().getName().matches("%.view.xml") } or`
`688`	`688`	`TJsonControl(JsonObject control) {`
`689`	`689`	`exists(JsonView view \| control.getParent() = view.getRoot().getPropValue("content"))`
`690`	`690`	`} or`