Skip to content

Commit ac8ee50

Browse files
committed
Convert more to using better predicate calls
1 parent 8c08f3d commit ac8ee50

File tree

1 file changed

+4
-7
lines changed
  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5

1 file changed

+4
-7
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -485,9 +485,8 @@ class CustomController extends SapExtendCall {
485485
* controller.
486486
*/
487487

488-
exists(DisplayEventHandler handler |
489-
handler.getAssociatedContextObject().getALocalSource() = this.getAThisNode() and
490-
result.getBinder() = handler
488+
exists(DisplayEventHandler handler | handler = result.getBinder() |
489+
handler.getAssociatedContextObject().getALocalSource() = this.getAThisNode()
491490
)
492491
}
493492

@@ -504,10 +503,8 @@ class CustomController extends SapExtendCall {
504503
}
505504

506505
RouterReference getARouterReference() {
507-
result.getMethodName() = "getRouter" and
508-
exists(ThisNode controllerThis |
509-
result.(MethodCallNode).getReceiver() = controllerThis.getALocalUse() and
510-
controllerThis.getBinder() = this.getAMethod()
506+
exists(ThisNode controllerThis | controllerThis.getBinder() = this.getAMethod() |
507+
result = controllerThis.getAMemberCall("getRouter")
511508
)
512509
}
513510

0 commit comments

Comments
 (0)