Port over UI5PathInjection

- Port over UI5PathInjection.
- Create a UI5PathInjectionQuery file and move the configuration there.
- Update expected results of the query.

Author: jeongsoolee09

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5PathInjectionQuery.qll

@@ -0,0 +1,9 @@
+import javascript
+
+module UI5PathInjection implements DataFlow::ConfigSig {
+  predicate isSource(DataFlow::Node node) { node instanceof RemoteFlowSource }
+
+  predicate isSink(DataFlow::Node node) {
+    node = ModelOutput::getASinkNode("ui5-path-injection").asSink()
+  }
+}

javascript/frameworks/ui5/src/UI5PathInjection/UI5PathInjection.ql

@@ -14,24 +14,20 @@
 
 import javascript
 import advanced_security.javascript.frameworks.ui5.dataflow.DataFlow
-import advanced_security.javascript.frameworks.ui5.dataflow.DataFlow::UI5PathGraph
+import advanced_security.javascript.frameworks.ui5.UI5PathInjectionQuery
 
-// import semmle.javascript.security.dataflow.TaintedPathQuery as TaintedPathQuery
-class UI5PathInjectionConfiguration extends TaintTracking::Configuration {
-  UI5PathInjectionConfiguration() { this = "UI5 Path Injection" }
+module UI5PathInjectionFlow = TaintTracking::Global<UI5PathInjection>;
 
-  override predicate isSource(DataFlow::Node node) { node instanceof RemoteFlowSource }
+module UI5PathInjectionPathGraph =
+  UI5PathGraph<UI5PathInjectionFlow::PathNode, UI5PathInjectionFlow::PathGraph>;
 
-  override predicate isSink(DataFlow::Node node) {
-    node = ModelOutput::getASinkNode("ui5-path-injection").asSink()
-  }
-}
+import UI5PathInjectionPathGraph 
 
 from
-  UI5PathInjectionConfiguration config, UI5PathNode source, UI5PathNode sink,
-  UI5PathNode primarySource
+  UI5PathInjectionPathGraph::UI5PathNode source, UI5PathInjectionPathGraph::UI5PathNode sink,
+  UI5PathInjectionPathGraph::UI5PathNode primarySource
 where
-  config.hasFlowPath(source.getPathNode(), sink.getPathNode()) and
+  UI5PathInjectionFlow::flowPath(source.getPathNode(), sink.getPathNode()) and
   primarySource = source.getAPrimarySource()
 select sink, primarySource, sink, "The path of a saved file depends on a $@.", primarySource,
   "user-provided value"

javascript/frameworks/ui5/test/queries/UI5PathInjection/path-custom-control-property-sanitized/UI5PathInjection.expected

@@ -1,4 +1,3 @@
-WARNING: type 'Configuration' has been deprecated and may be removed in future (UI5PathInjection.ql:20,45-73)
 nodes
 | webapp/control/xss.js:8:23:8:37 | { type: "int" } |
 | webapp/control/xss.js:17:43:17:60 | oControl.getText() |

javascript/frameworks/ui5/test/queries/UI5PathInjection/path-custom-control-sanitized/UI5PathInjection.expected

@@ -1,4 +1,3 @@
-WARNING: type 'Configuration' has been deprecated and may be removed in future (UI5PathInjection.ql:20,45-73)
 nodes
 | webapp/control/xss.js:9:23:9:40 | { type: "string" } |
 | webapp/control/xss.js:15:21:15:46 | value |

javascript/frameworks/ui5/test/queries/UI5PathInjection/path-html-control-df/UI5PathInjection.expected

@@ -1,4 +1,3 @@
-WARNING: type 'Configuration' has been deprecated and may be removed in future (UI5PathInjection.ql:20,45-73)
 nodes
 | webapp/controller/app.controller.js:10:17:10:27 | input: null |
 | webapp/controller/app.controller.js:16:39:16:66 | oModel. ... input') |