Skip to content

Commit 70cc904

Browse files
committed
Convert more to using better predicate calls
1 parent 78ec643 commit 70cc904

File tree

1 file changed

+3
-7
lines changed
  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5

1 file changed

+3
-7
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -218,9 +218,7 @@ class JQueryDefineModule extends UserModule, MethodCallExpr {
218218
exists(JQuerySap jQuerySap | this = jQuerySap.getAMemberCall(["declare", "define"]).asExpr())
219219
}
220220

221-
override string getADependency() {
222-
result = this.getArgument(0).getALocalSource().getStringValue()
223-
}
221+
override string getADependency() { result = this.getArgument(0).getStringValue() }
224222

225223
override string getModuleFileRelativePath() { result = this.getFile().getRelativePath() }
226224

@@ -588,13 +586,11 @@ class RoutingTarget extends MethodCallNode {
588586
}
589587

590588
MethodCallNode getAnAttachDisplayCall() {
591-
result.getReceiver().getALocalSource() = routerReference.getATarget() and
592-
result.getMethodName() = "attachDisplay"
589+
result = routerReference.getATarget().getAMemberCall("attachDisplay")
593590
}
594591

595592
MethodCallNode getADetachDisplayCall() {
596-
result.getReceiver().getALocalSource() = routerReference.getATarget() and
597-
result.getMethodName() = "detachDisplay"
593+
result = routerReference.getATarget().getAMemberCall("detachDisplay")
598594
}
599595
}
600596

0 commit comments

Comments
 (0)