Make definition of ImplMethodCallApplicationServiceDefinition more idiomatic

jeongsoolee09 · jeongsoolee09 · commit 6fd6b2a67c25 · 2025-06-17T13:20:27.000-04:00
diff --git a/javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CDS.qll b/javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CDS.qll
@@ -494,10 +494,7 @@ class ImplMethodCallApplicationServiceDefinition extends MethodCallNode,
   UserDefinedApplicationService
 {
   ImplMethodCallApplicationServiceDefinition() {
-    exists(CdsFacade cds |
-      this.getReceiver() = cds.getMember("service").asSource() and
-      this.getMethodName() = "impl"
-    )
+    exists(CdsFacade cds | this = cds.getMember("service").getMember("impl").getACall())
   }
 
   override FunctionNode getInitFunction() { result = this.getArgument(0) }

Original file line number	Diff line number	Diff line change
`@@ -494,10 +494,7 @@ class ImplMethodCallApplicationServiceDefinition extends MethodCallNode,`
`494`	`494`	`UserDefinedApplicationService`
`495`	`495`	`{`
`496`	`496`	`ImplMethodCallApplicationServiceDefinition() {`
`497`		`- exists(CdsFacade cds \|`
`498`		`- this.getReceiver() = cds.getMember("service").asSource() and`
`499`		`- this.getMethodName() = "impl"`
`500`		`- )`
	`497`	`+ exists(CdsFacade cds \| this = cds.getMember("service").getMember("impl").getACall())`
`501`	`498`	`}`
`502`	`499`
`503`	`500`	`override FunctionNode getInitFunction() { result = this.getArgument(0) }`