ContainerAlgorithms::erase_all_occurrences removed - use std::erase(vec, value)

VioletGiraffe · VioletGiraffe · commit 416b8d1a501e · 2025-12-27T17:16:46.000+02:00
diff --git a/container/algorithms.hpp b/container/algorithms.hpp
@@ -9,12 +9,6 @@ namespace ContainerAlgorithms {
 // Erases all matching elements from the container
 //
 
-template <class ContainerType, typename ArgumentType>
-inline void erase_all_occurrences(ContainerType& container, const ArgumentType& item)
-{
-	container.erase(std::remove(container.begin(), container.end(), item), container.end());
-}
-
 template <class ContainerType, typename PredicateType>
 inline void erase_if(ContainerType& container, PredicateType&& unaryPredicate)
 {
diff --git a/utility/callback_caller.hpp b/utility/callback_caller.hpp
@@ -1,7 +1,5 @@
 #pragma once
 
-#include "../container/algorithms.hpp"
-
 #include <algorithm>
 #include <assert.h>
 #include <vector>
@@ -17,7 +15,7 @@ class CallbackCaller {
 
 	void removeSubscriber(Interface* instance)
 	{
-		ContainerAlgorithms::erase_all_occurrences(_subscribers, instance);
+		std::erase(_subscribers, instance);
 	}
 
 	template <typename MethodPointer, typename ...Args>

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`	`1`	`#pragma once`
`2`	`2`
`3`		`-#include "../container/algorithms.hpp"`
`4`		`-`
`5`	`3`	`#include <algorithm>`
`6`	`4`	`#include <assert.h>`
`7`	`5`	`#include <vector>`
`@@ -17,7 +15,7 @@ class CallbackCaller {`
`17`	`15`
`18`	`16`	`void removeSubscriber(Interface* instance)`
`19`	`17`	`{`
`20`		`- ContainerAlgorithms::erase_all_occurrences(_subscribers, instance);`
	`18`	`+ std::erase(_subscribers, instance);`
`21`	`19`	`}`
`22`	`20`
`23`	`21`	`template <typename MethodPointer, typename ...Args>`