Merge pull request #2511 from ViewComponent/2483-translation-fix

Allow I18n calls in render?

Author: joelhawksley

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 6
 
 ## main
 
+* Allow I18n calls in `render?`.
+
+    *23tux*
+
 * ViewComponent now works without `rails` and `railties` gems loaded, enabling compatibility with Bridgetown 2.0.
 
     *Tom Lord*

lib/view_component/base.rb

@@ -131,15 +131,14 @@ def render_in(view_context, &block)
 
       @__vc_content_evaluated = false
       @__vc_render_in_block = block
+      @view_context.instance_variable_set(:@virtual_path, virtual_path)
 
       before_render
 
       if render?
         value = nil
 
         @output_buffer.with_buffer do
-          @view_context.instance_variable_set(:@virtual_path, virtual_path)
-
           rendered_template =
             around_render do
               render_template_for(@__vc_requested_details).to_s

test/sandbox/config/locales/en.yml

@@ -24,3 +24,7 @@ en:
 
   my_component:
     message: "OH NO! (you shouldn't see me)"
+
+  rendering_test:
+    i18n_test_component:
+      message: "I can be called in render?"

test/sandbox/test/rendering_test.rb

@@ -1344,4 +1344,25 @@ def test_render_partial_with_yield_and_method_call
     render_inline(PartialWithYieldAndMethodCallComponent.new)
     assert_text "hello world", exact: true, normalize_ws: true
   end
+
+  class I18nTestComponent < ViewComponent::Base
+    def message
+      t(".message")
+    end
+
+    def render?
+      message
+    end
+
+    def call
+      content_tag :div, t(".message")
+    end
+  end
+
+  def test_i18n_in_render_hook
+    vc_test_request.params[:hello] = "world"
+    render_inline(I18nTestComponent.new)
+
+    assert_selector("div", text: I18n.t("rendering_test.i18n_test_component.message"))
+  end
 end