Skip to content

Commit 78e7e84

Browse files
authored
Merge pull request #2509 from ViewComponent/active-scaffold-compat
update docs to remove known issue with ActiveScaffold
2 parents 9095351 + 38bf647 commit 78e7e84

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ nav_order: 6
1010

1111
## main
1212

13+
* Remove known issue from docs as ActiveScaffold is [now compatible](https://github.com/activescaffold/active_scaffold/pull/743) with ViewComponent.
14+
15+
*David Löwenfels*
16+
1317
* Add test to document the current behavior for resolving relative translation keys within partial blocks. When rendering a partial, relative translation keys are resolved relative to the partial's own path rather than the caller’s path. This test ensures that this behavior remains consistent.
1418

1519
*Oussama Hilal*

docs/known_issues.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,3 @@ Calls to form helpers such as `form_with` in ViewComponents [don't use the defau
1717
<%= f.text_field :name %>
1818
<% end %>
1919
```
20-
21-
## Incompatibility with `active_scaffold`
22-
23-
Due to `active_scaffold`'s [monkey-patching](https://github.com/activescaffold/active_scaffold/blob/0ada8b7a51bf608c4ade18983ce4494c963963f3/lib/active_scaffold/extensions/action_view_rendering.rb) of `render` that hasn't been updated to support renderable objects like ViewComponents, it's impossible to use `active_scaffold` alongside `view_component`.

0 commit comments

Comments
 (0)