Fix compiler warnings seen with Clang 21

Author: bdash

arch/armv7/CMakeLists.txt

@@ -44,7 +44,7 @@ if(BN_INTERNAL_BUILD)
 		RUNTIME_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR})
 endif()
 
-if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
 	target_compile_options(arch_armv7 PRIVATE
 		$<$<COMPILE_LANGUAGE:CXX>:-Wno-deprecated-enum-enum-conversion>
 	)

arch/armv7/arch_armv7.cpp

@@ -884,12 +884,10 @@ class Armv7Architecture: public ArmCommonArchitecture
 		const InstructionOperand& op,
 		vector<InstructionTextToken>& result)
 	{
-		const char* reg = NULL;
-		reg = GetRegisterName((enum Register)op.reg).c_str();
-		if (reg == NULL)
+		auto reg = GetRegisterName((enum Register)op.reg);
+		if (reg.empty())
 			return FAILED_TO_DISASSEMBLE_REGISTER;
 
-
 		result.emplace_back(RegisterToken, reg);
 		tokenize_shift(op, result);
 		return DISASM_SUCCESS;

demangler/gnu3/demangle_gnu3.cpp

@@ -471,7 +471,7 @@ DemangledTypeNode DemangleGNU3::DemangleFunction(bool cnst, bool vltl)
 	old_isparam = m_isParameter;
 	m_isParameter = true;
 	m_functionSubstitute.push_back({});
-	int i = 0;
+	[[maybe_unused]] int i = 0;
 	while (m_reader.Peek() != 'E')
 	{
 		DemangledTypeNode param = DemangleType();