Missing \

[123billybob321]

In the https://github.com/VERT-sh/VERT/blob/main/docs/DOCKER.md code, I think there is a missing \

$ docker build -t vert-sh/vert \ --build-arg PUB_ENV=production \ --build-arg PUB_HOSTNAME=vert.sh \ --build-arg PUB_PLAUSIBLE_URL=https://plausible.example.com \ --build-arg PUB_VERTD_URL=https://vertd.vert.sh \ --build-arg PUB_DONATION_URL=https://donations.vert.sh \ --build-arg PUB_DISABLE_ALL_EXTERNAL_REQUESTS=false --build-arg PUB_STRIPE_KEY="" .

--build-arg PUB_DISABLE_ALL_EXTERNAL_REQUESTS=false

should be

--build-arg PUB_DISABLE_ALL_EXTERNAL_REQUESTS=false \

Also, is the docker compose for the manual build correct? It states

image: ghcr.io/vert-sh/vert:latest

Should this be

image: vert-sh/vert

Like the docker run command?

[azurejelly]

In the https://github.com/VERT-sh/VERT/blob/main/docs/DOCKER.md code, I think there is a missing \

$ docker build -t vert-sh/vert \ --build-arg PUB_ENV=production \ --build-arg PUB_HOSTNAME=vert.sh \ --build-arg PUB_PLAUSIBLE_URL=https://plausible.example.com \ --build-arg PUB_VERTD_URL=https://vertd.vert.sh \ --build-arg PUB_DONATION_URL=https://donations.vert.sh \ --build-arg PUB_DISABLE_ALL_EXTERNAL_REQUESTS=false --build-arg PUB_STRIPE_KEY="" .

--build-arg PUB_DISABLE_ALL_EXTERNAL_REQUESTS=false

should be

--build-arg PUB_DISABLE_ALL_EXTERNAL_REQUESTS=false \

oops, yes, the command is missing a \

Also, is the docker compose for the manual build correct? It states

image: ghcr.io/vert-sh/vert:latest

Should this be

image: vert-sh/vert

Like the docker run command?

the image name is correct in this case because a lot of people are 100% gonna copy & paste the docker-compose.yml file in this repo without paying much attention

however, this part can also be improved. for docker to build the image you need to use docker compose build or docker compose up --build, and thats not specified in the docs anywhere

[123billybob321]

Thanks.

I'm very much a beginner when it comes to docker but I've got it working building from the source but in a different way. It seems to accept the environmental variables so I assume it's doing it correctly?

Basically I go in to the folder and run the docker build script as above. Once completed, I do a docker compose up -d but with
image: vert-sh/vert

I tried the docker compose build command but got an error.

[theFoxCost]

btw i made a bash script to automatically do all that boring stuff fast #194

[theFoxCost]

this issue should be closed