-
Notifications
You must be signed in to change notification settings - Fork 3
Description
It seems that sometimes TMDB is returning English responses instead of the requested language.
This is based on these two test runs of the same code:
https://github.com/UniversalMediaServer/api/actions/runs/4726660979/jobs/8386466092?pr=1182
https://github.com/UniversalMediaServer/api/actions/runs/4726660652/jobs/8386465584?pr=1182
search the logs for tv tmdbData 1 and you'll see one of them received an English result, and one received a French result. The French result is the correct one.
Note that we have fixed this test flakiness now by mocking the response in #1182 but in production the bug will still be happening.
If we can confirm it more, maybe we should report the bug to TMDB. It's possible that it's not a bug with the TMDB service itself though, like maybe network caching or a fallback in the third-party Node library code. Those things should be ruled out before reporting to them. It's worth noting that I can't reproduce the failure at all locally, even when I ran it hundreds of times in a loop.
You can restore the unmocked behaviour for debugging this by removing the TMDB_API_KEY=foo from the test:mocks script in package.json