Skip to content

Commit 14696eb

Browse files
authored
Merge pull request #2780 from UltimateHackingKeyboard/fix-firmware-upgrade-validation
fix: remove Agent upgrade validation from the upgrade firmware flow
2 parents 2a236d6 + 6cf503d commit 14696eb

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

packages/uhk-agent/src/services/device.service.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import {
4141
RIGHT_HALF_FIRMWARE_UPGRADE_MODULE_NAME,
4242
RightSlotModules,
4343
SaveUserConfigurationData,
44-
shouldUpgradeAgent,
4544
shouldUpgradeFirmware,
4645
simulateInvalidUserConfigError,
4746
UHK_80_DEVICE,
@@ -511,12 +510,6 @@ export class DeviceService {
511510

512511
uhkDeviceProduct = await getCurrentUhkDeviceProduct(this.options);
513512
checkFirmwareAndDeviceCompatibility(packageJson, uhkDeviceProduct);
514-
if (shouldUpgradeAgent(packageJson.userConfigVersion, this.disableAgentUpgrade)) {
515-
response.failReason = FirmwareUpgradeFailReason.UserConfigVersionNotSupported;
516-
this.logService.error(`[DeviceService] The firmware contains ${packageJson.userConfigVersion} user config version, which is newer than ${VERSIONS.userConfigVersion} which this Agent supports. Minor version check is used.`);
517-
518-
return event.sender.send(IpcEvents.device.updateFirmwareReply, response);
519-
}
520513

521514
let dongleHid = await getCurrentUhkDongleHID();
522515
if (dongleHid) {

0 commit comments

Comments
 (0)