style: use recommended prefer-const eslint rule (#2790)

ert78gb · web-flow · commit 071e4f9503d6 · 2026-01-08T19:32:58.000+01:00
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -35,7 +35,6 @@ export const typescriptRules = {
     'no-async-promise-executor': 'off',
     'no-case-declarations': 'off',
     'no-prototype-builtins': 'off',
-    'prefer-const': 'off',
 }
 
 export default [
diff --git a/packages/mcumgr/src/util/cbor.ts b/packages/mcumgr/src/util/cbor.ts
@@ -21,14 +21,14 @@ export function encode(value: any) {
 
     function prepareWrite(length: number) {
         let newByteLength = data.byteLength;
-        let requiredLength = offset + length;
+        const requiredLength = offset + length;
         while (newByteLength < requiredLength)
             newByteLength <<= 1;
         if (newByteLength !== data.byteLength) {
-            let oldDataView = dataView;
+            const oldDataView = dataView;
             data = new ArrayBuffer(newByteLength);
             dataView = new DataView(data);
-            let uint32count = (offset + 3) >> 2;
+            const uint32count = (offset + 3) >> 2;
             for (let i = 0; i < uint32count; ++i)
                 dataView.setUint32(i << 2, oldDataView.getUint32(i << 2));
         }
@@ -46,7 +46,7 @@ export function encode(value: any) {
         commitWrite(prepareWrite(1).setUint8(offset, value));
     }
     function writeUint8Array(value) {
-        let dataView = prepareWrite(value.length);
+        const dataView = prepareWrite(value.length);
         for (let i = 0; i < value.length; ++i)
             dataView.setUint8(offset + i, value[i]);
         commitWrite();
@@ -58,9 +58,9 @@ export function encode(value: any) {
         commitWrite(prepareWrite(4).setUint32(offset, value));
     }
     function writeUint64(value) {
-        let low = value % POW_2_32;
-        let high = (value - low) / POW_2_32;
-        let dataView = prepareWrite(8);
+        const low = value % POW_2_32;
+        const high = (value - low) / POW_2_32;
+        const dataView = prepareWrite(8);
         dataView.setUint32(offset, high);
         dataView.setUint32(offset + 4, low);
         commitWrite();
@@ -107,7 +107,7 @@ export function encode(value: any) {
                 return writeFloat64(value);
 
             case "string":
-                let utf8data = [];
+                const utf8data = [];
                 for (i = 0; i < value.length; ++i) {
                     let charCode = value.charCodeAt(i);
                     if (charCode < 0x80) {
@@ -145,11 +145,11 @@ export function encode(value: any) {
                     writeTypeAndLength(2, value.length);
                     writeUint8Array(value);
                 } else {
-                    let keys = Object.keys(value);
+                    const keys = Object.keys(value);
                     length = keys.length;
                     writeTypeAndLength(5, length);
                     for (i = 0; i < length; ++i) {
-                        let key = keys[i];
+                        const key = keys[i];
                         encodeItem(key);
                         encodeItem(value[key]);
                     }
@@ -162,15 +162,15 @@ export function encode(value: any) {
     if ("slice" in data)
         return data.slice(0, offset);
 
-    let ret = new ArrayBuffer(offset);
-    let retView = new DataView(ret);
+    const ret = new ArrayBuffer(offset);
+    const retView = new DataView(ret);
     for (let i = 0; i < offset; ++i)
         retView.setUint8(i, dataView.getUint8(i));
     return ret;
 }
 
 export function decode(data: any, tagger?: Function, simpleValue?: Function) {
-    let dataView = new DataView(data);
+    const dataView = new DataView(data);
     let offset = 0;
 
     if (typeof tagger !== "function")
@@ -186,13 +186,13 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
         return commitRead(length, new Uint8Array(data, offset, length));
     }
     function readFloat16() {
-        let tempArrayBuffer = new ArrayBuffer(4);
-        let tempDataView = new DataView(tempArrayBuffer);
-        let value = readUint16();
+        const tempArrayBuffer = new ArrayBuffer(4);
+        const tempDataView = new DataView(tempArrayBuffer);
+        const value = readUint16();
 
-        let sign = value & 0x8000;
+        const sign = value & 0x8000;
         let exponent = value & 0x7c00;
-        let fraction = value & 0x03ff;
+        const fraction = value & 0x03ff;
 
         if (exponent === 0x7c00)
             exponent = 0xff << 10;
@@ -244,10 +244,10 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
         throw "Invalid length encoding";
     }
     function readIndefiniteStringLength(majorType) {
-        let initialByte = readUint8();
+        const initialByte = readUint8();
         if (initialByte === 0xff)
             return -1;
-        let length = readLength(initialByte & 0x1f);
+        const length = readLength(initialByte & 0x1f);
         if (length < 0 || (initialByte >> 5) !== majorType)
             throw "Invalid indefinite length element";
         return length;
@@ -286,9 +286,9 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
     }
 
     function decodeItem() {
-        let initialByte = readUint8();
-        let majorType = initialByte >> 5;
-        let additionalInformation = initialByte & 0x1f;
+        const initialByte = readUint8();
+        const majorType = initialByte >> 5;
+        const additionalInformation = initialByte & 0x1f;
         let i;
         let length;
 
@@ -314,13 +314,13 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
                 return -1 - length;
             case 2:
                 if (length < 0) {
-                    let elements = [];
+                    const elements = [];
                     let fullArrayLength = 0;
                     while ((length = readIndefiniteStringLength(majorType)) >= 0) {
                         fullArrayLength += length;
                         elements.push(readArrayBuffer(length));
                     }
-                    let fullArray = new Uint8Array(fullArrayLength);
+                    const fullArray = new Uint8Array(fullArrayLength);
                     let fullArrayOffset = 0;
                     for (i = 0; i < elements.length; ++i) {
                         fullArray.set(elements[i], fullArrayOffset);
@@ -330,7 +330,7 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
                 }
                 return readArrayBuffer(length);
             case 3:
-                let utf16data = [];
+                const utf16data = [];
                 if (length < 0) {
                     while ((length = readIndefiniteStringLength(majorType)) >= 0)
                         appendUtf16Data(utf16data, length);
@@ -350,9 +350,9 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
                 }
                 return retArray;
             case 5:
-                let retObject = {};
+                const retObject = {};
                 for (i = 0; i < length || length < 0 && !readBreak(); ++i) {
-                    let key = decodeItem();
+                    const key = decodeItem();
                     retObject[key] = decodeItem();
                 }
                 return retObject;
@@ -374,7 +374,7 @@ export function decode(data: any, tagger?: Function, simpleValue?: Function) {
         }
     }
 
-    let ret = decodeItem();
+    const ret = decodeItem();
     if (offset !== data.byteLength)
         throw "Remaining bytes";
     return ret;
diff --git a/packages/uhk-agent/src/util/backup-user-configuration.ts b/packages/uhk-agent/src/util/backup-user-configuration.ts
@@ -67,7 +67,7 @@ export async function getBackupUserConfigurationContent(logService: LogService,
 }
 
 export async function getCompatibleUserConfigFromHistory(logService: LogService, uniqueId: number): Promise<BackupUserConfiguration> {
-    let history = await loadUserConfigHistoryAsync();
+    const history = await loadUserConfigHistoryAsync();
 
     const deviceHistory = history.devices.find(device => device.uniqueId === uniqueId);
 
diff --git a/packages/uhk-common/src/config-serializer/config-items/key-action/key-action.ts b/packages/uhk-common/src/config-serializer/config-items/key-action/key-action.ts
@@ -28,7 +28,7 @@ export enum KeyActionId {
     MacroArgumentAction          = 40,
 }
 
-export let keyActionType = {
+export const keyActionType = {
     NoneAction                   : 'none',
     KeystrokeAction              : 'keystroke',
     SwitchLayerAction            : 'switchLayer',
diff --git a/packages/uhk-common/src/config-serializer/config-items/macro-action/macro-action.ts b/packages/uhk-common/src/config-serializer/config-items/macro-action/macro-action.ts
@@ -36,7 +36,7 @@ export enum MacroMouseSubAction {
     release = 2
 }
 
-export let macroActionType = {
+export const macroActionType = {
     KeyMacroAction                  : 'key',
     MouseButtonMacroAction          : 'mouseButton',
     MoveMouseMacroAction            : 'moveMouse',
diff --git a/packages/uhk-common/src/config-serializer/config-items/module-configuration.ts b/packages/uhk-common/src/config-serializer/config-items/module-configuration.ts
@@ -280,7 +280,7 @@ export class ModuleConfiguration {
         this.navigationModeFn4Layer = buffer.readUInt8();
         this.navigationModeFn5Layer = buffer.readUInt8();
 
-        let numberOfProperties = buffer.readUInt8();
+        const numberOfProperties = buffer.readUInt8();
 
         for(let index = 0; index < numberOfProperties; index++){
             const property = buffer.readUInt8();
diff --git a/packages/uhk-common/src/config-serializer/config-items/module.ts b/packages/uhk-common/src/config-serializer/config-items/module.ts
@@ -230,7 +230,7 @@ export class Module {
     getKeyActionsCount(): number {
         let count  = 0
 
-        for (let keyAction of this.keyActions) {
+        for (const keyAction of this.keyActions) {
             count++;
 
             if (keyAction instanceof PlayMacroAction) {
diff --git a/packages/uhk-usb/src/uhk-hid-device.ts b/packages/uhk-usb/src/uhk-hid-device.ts
@@ -483,7 +483,7 @@ export class UhkHidDevice {
 
         while (new Date().getTime() - startTime.getTime() < waitTimeout) {
             iteration++;
-            let allDevice = [];
+            const allDevice = [];
             for (const vidPid of vidPidPairs) {
 
                 if (enumerationMode === EnumerationModes.Bootloader && device.firmwareUpgradeMethod === FIRMWARE_UPGRADE_METHODS.MCUBOOT) {
diff --git a/packages/uhk-usb/src/utils/convert-ms-to-duration.ts b/packages/uhk-usb/src/utils/convert-ms-to-duration.ts
@@ -1,13 +1,13 @@
 import { Duration } from '../models/duration.js';
 
 export function convertMsToDuration(milliseconds: number): Duration {
-    let days, hours, minutes, seconds;
+    let hours, minutes, seconds;
     seconds = Math.floor(milliseconds / 1000);
     minutes = Math.floor(seconds / 60);
     seconds = seconds % 60;
     hours = Math.floor(minutes / 60);
     minutes = minutes % 60;
-    days = Math.floor(hours / 24);
+    const days = Math.floor(hours / 24);
     hours = hours % 24;
 
     return { days, hours, minutes, seconds };
diff --git a/packages/uhk-usb/src/utils/list-available-devices.ts b/packages/uhk-usb/src/utils/list-available-devices.ts
@@ -35,7 +35,7 @@ export async function listAvailableDevices(options: ListAvailableDevicesOptions)
         prevDevice.state = UsbDeviceConnectionStates.Unknown;
     }
 
-    let hidDevices = options.hidDevices ?? await getUhkHidDevices();
+    const hidDevices = options.hidDevices ?? await getUhkHidDevices();
     for (const hidDevice of hidDevices) {
         const id = `h-${hidDevice.vendorId}-${hidDevice.productId}-${hidDevice.interface}`
         const existingPrevDevice = prevDevices.get(id);
@@ -53,7 +53,7 @@ export async function listAvailableDevices(options: ListAvailableDevicesOptions)
         }
     }
 
-    let serialDevices = options.serialDevices ?? await SerialPort.list();
+    const serialDevices = options.serialDevices ?? await SerialPort.list();
     for (const serialDevice of serialDevices) {
         const id = `s-${serialDevice.vendorId}-${serialDevice.productId}-${serialDevice.path}`
         const existingPrevDevice = prevDevices.get(id);
diff --git a/packages/uhk-web/src/app/components/svg/keys/svg-keystroke-key/svg-keystroke-key.component.ts b/packages/uhk-web/src/app/components/svg/keys/svg-keystroke-key/svg-keystroke-key.component.ts
@@ -91,8 +91,7 @@ export class SvgKeystrokeKeyComponent implements OnChanges {
             if (this.labelSource) {
                 this.labelType = 'icon';
             } else {
-                let newLabelSource: string[];
-                newLabelSource = this.mapper.scanCodeToText(scancode, this.keystrokeAction.type);
+                const newLabelSource = this.mapper.scanCodeToText(scancode, this.keystrokeAction.type);
                 if (newLabelSource) {
                     if (this.secondaryText && newLabelSource.length === 2) {
                         if (isRectangleAsSecondaryRole || bottomSideMode) {
diff --git a/packages/uhk-web/src/app/services/monaco-editor-completion-item-provider.ts b/packages/uhk-web/src/app/services/monaco-editor-completion-item-provider.ts
@@ -75,7 +75,7 @@ export class MonacoEditorCompletionItemProvider implements monaco.languages.Comp
         }
 
         const monacoSuggestions: monaco.languages.CompletionItem[] = nelaSuggestions.map(it => {
-            let kind = this.guessKind(it.suggestion, it.originRule);
+            const kind = this.guessKind(it.suggestion, it.originRule);
 
             return {
                 insertText: it.text(),
diff --git a/packages/uhk-web/src/app/services/uhk80-migrator.service.ts b/packages/uhk-web/src/app/services/uhk80-migrator.service.ts
@@ -44,7 +44,7 @@ export class Uhk80MigratorService implements OnDestroy {
             return userConfig;
         }
 
-        let hasConfiguredExcessKey = this.hasUhk80ConfiguredExcessKey(userConfig);
+        const hasConfiguredExcessKey = this.hasUhk80ConfiguredExcessKey(userConfig);
 
         if (hasConfiguredExcessKey) {
             return userConfig;
diff --git a/packages/uhk-web/src/app/store/reducers/user-configuration.ts b/packages/uhk-web/src/app/store/reducers/user-configuration.ts
@@ -1306,7 +1306,7 @@ function generateName(items: { name: string }[], name: string) {
 
 function generateMacroId(macros: Macro[]) {
     let newId = 0;
-    let usedMacroIds = new Set();
+    const usedMacroIds = new Set();
 
     macros.forEach((macro: Macro) => {
         if (macro.id > newId) {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ export const typescriptRules = {`
`35`	`35`	`'no-async-promise-executor': 'off',`
`36`	`36`	`'no-case-declarations': 'off',`
`37`	`37`	`'no-prototype-builtins': 'off',`
`38`		`- 'prefer-const': 'off',`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`export default [`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export async function getBackupUserConfigurationContent(logService: LogService,`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`export async function getCompatibleUserConfigFromHistory(logService: LogService, uniqueId: number): Promise<BackupUserConfiguration> {`
`70`		`- let history = await loadUserConfigHistoryAsync();`
	`70`	`+ const history = await loadUserConfigHistoryAsync();`
`71`	`71`
`72`	`72`	`const deviceHistory = history.devices.find(device => device.uniqueId === uniqueId);`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export enum KeyActionId {`
`28`	`28`	`MacroArgumentAction = 40,`
`29`	`29`	`}`
`30`	`30`
`31`		`-export let keyActionType = {`
	`31`	`+export const keyActionType = {`
`32`	`32`	`NoneAction : 'none',`
`33`	`33`	`KeystrokeAction : 'keystroke',`
`34`	`34`	`SwitchLayerAction : 'switchLayer',`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export enum MacroMouseSubAction {`
`36`	`36`	`release = 2`
`37`	`37`	`}`
`38`	`38`
`39`		`-export let macroActionType = {`
	`39`	`+export const macroActionType = {`
`40`	`40`	`KeyMacroAction : 'key',`
`41`	`41`	`MouseButtonMacroAction : 'mouseButton',`
`42`	`42`	`MoveMouseMacroAction : 'moveMouse',`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export async function listAvailableDevices(options: ListAvailableDevicesOptions)`
`35`	`35`	`prevDevice.state = UsbDeviceConnectionStates.Unknown;`
`36`	`36`	`}`
`37`	`37`
`38`		`- let hidDevices = options.hidDevices ?? await getUhkHidDevices();`
	`38`	`+ const hidDevices = options.hidDevices ?? await getUhkHidDevices();`
`39`	`39`	`for (const hidDevice of hidDevices) {`
`40`	`40`	const id = `h-${hidDevice.vendorId}-${hidDevice.productId}-${hidDevice.interface}`
`41`	`41`	`const existingPrevDevice = prevDevices.get(id);`
`@@ -53,7 +53,7 @@ export async function listAvailableDevices(options: ListAvailableDevicesOptions)`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`- let serialDevices = options.serialDevices ?? await SerialPort.list();`
	`56`	`+ const serialDevices = options.serialDevices ?? await SerialPort.list();`
`57`	`57`	`for (const serialDevice of serialDevices) {`
`58`	`58`	const id = `s-${serialDevice.vendorId}-${serialDevice.productId}-${serialDevice.path}`
`59`	`59`	`const existingPrevDevice = prevDevices.get(id);`