Conversation
github-actions
bot
added
test:uipath-langchain
pateljay43
reviewed
Jan 7, 2026
| index_name: Optional[str] = Field(None, alias="indexName") | ||
| folder_path: Optional[str] = Field(None, alias="folderPath") | ||
| query: Optional[AgentContextQuerySetting] = Field(None) | ||
| folder_path_prefix: Optional[AgentContextQuerySetting] = Field( |
pateljay43
reviewed
Jan 7, 2026
Comment on lines
+412
to
+417
| citation_mode: Optional[AgentContextValueSetting] = Field( | ||
| None, alias="citationMode" | ||
| ) | ||
| file_extension: Optional[AgentContextValueSetting] = Field( | ||
| None, alias="fileExtension" | ||
| ) |
There was a problem hiding this comment.
AgentContextValueSetting has Any type for value. Do not use Any anywhere and type everything. including enums (string or int).
pateljay43
reviewed
Jan 7, 2026
Comment on lines
+406
to
+407
| index_name: Optional[str] = Field(None, alias="indexName") | ||
| folder_path: Optional[str] = Field(None, alias="folderPath") |
There was a problem hiding this comment.
we are not supporting deeprag with index mode as internal tool atm. only JIT/Attachments for now for DeepRAG Internal tool
pateljay43
reviewed
Jan 7, 2026
| class AgentInternalDeepRagSettings(BaseCfg): | ||
| """Agent internal DeepRAG tool settings model.""" | ||
|
|
||
| context_type: str = Field(..., alias="contextType") |
pateljay43
reviewed
Jan 7, 2026
|
|
||
| class AgentInternalToolProperties(BaseResourceProperties): | ||
| """Agent internal tool properties model.""" | ||
| class AgentInternalDeepRagSettings(BaseCfg): |
There was a problem hiding this comment.
there should be sub class based on context_type value (Annotated/Union)
pateljay43
reviewed
Jan 7, 2026
Comment on lines
+420
to
+425
| class AgentInternalBatchTransformSettings(BaseCfg): | ||
| """Agent internal BatchTransform tool settings model.""" | ||
|
|
||
| context_type: str = Field(..., alias="contextType") | ||
| index_name: Optional[str] = Field(None, alias="indexName") | ||
| folder_path: Optional[str] = Field(None, alias="folderPath") |
pateljay43
reviewed
Jan 7, 2026
| context_type: str = Field(..., alias="contextType") | ||
| index_name: Optional[str] = Field(None, alias="indexName") | ||
| folder_path: Optional[str] = Field(None, alias="folderPath") | ||
| query: Optional[str] = Field(None) |
There was a problem hiding this comment.
this is not string. it should be a model with variant and value and description
pateljay43
reviewed
Jan 7, 2026
There was a problem hiding this comment.
almost all properties should not be optional. they are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are transitioning deeprag and batch transform to be internal tools. This updates the python to match and allows the tools to be used in unified runtime.
also needed: UiPath/uipath-langchain-python#390