Skip to content

Commit 722418b

Browse files
authored
Major update to support correct CI ordering (#9)
* Major update to support correct CI ordering and implement #3 >[!IMPORTANT] > Tests will fail until [dependency bug](UbiquityDotNET/CSemVer.GitBuild#64) is resolved * Made case sensitivity for comparison a part of SemVer. - It is an error to attempt to compare versions expecting a different sort ordering. - Made Distinct IComparer<T> implementations for case internal as nothing should override the requirements defined for a given version. * Created internal helper for creating an ordered version so it is usable by CSemVer AND CSemVerCI * Added parsing a CSemVer from a `ParsedBuildVersionXml` as a method for use in testing. (File based variant now loads the file and calls this) * Major surgery to CSemVerCI to correctly support Patch+1 semantics - Now has a BaseBuild property to report the version it is based on (PatBuild-1 effectively) - Full version has Patch+1 version as it's core version * as a CI build it ALWAYS has "pre-release" componets (in SemVer terms) and is therefore always ordered BEFORE any such release but AFTER the base build release. This is the key to how CSemVer-CI works and is now implemented with correct understanding. (Spec isn't especially clear on this point) - Added PrereleaseVersion property to get at preRelease information for the build. * FileVersionQuad is now parsable from a '.' delimited string of integers. * Updated to leverage fixes in dependent Tasks package --------- Co-authored-by: smaillet <[email protected]>
1 parent bad52a8 commit 722418b

24 files changed

+735
-637
lines changed

Build-All.ps1

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ try
4949
}
5050

5151
mkdir $buildInfo['NuGetOutputPath'] -ErrorAction SilentlyContinue | Out-Null
52-
.\New-GeneratedVersionProps.ps1 $buildInfo
5352
dotnet build -c $Configuration --no-incremental 'src/Ubiquity.NET.Versioning.slnx'
5453
}
5554
catch

Directory.Build.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<Error Condition="'$(ImplicitUsings)'!='disable'" Code="REPO001" Text="$(MSBuildProjectFile) - Projects in this repository MUST NOT have ImplicitUsings enabled!"/>
4242

4343
<!--
44-
Until issue https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3902 is resolved this directly test for the missing stylecop.json file.
44+
Until issue https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3902 is resolved, this directly tests for the missing stylecop.json file.
4545
Given that was opened nearly a year ago and that it went 2 months to even get a comment about the cause, it seems unlikely that will receive a
4646
fix any time soon...
4747
-->

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Global references are included in ALL projects in this repository
55
-->
66
<ItemGroup>
7-
<GlobalPackageReference Include="Ubiquity.NET.Versioning.Build.Tasks" Version="5.0.4"/>
7+
<GlobalPackageReference Include="Ubiquity.NET.Versioning.Build.Tasks" Version="5.0.5-alpha"/>
88

99
<!--
1010
NOTE: This analyzer is sadly, perpetually in "pre-release" mode. There have been many issues/discussion on the point

IgnoredWords.dic

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ pages
112112
Paket
113113
param
114114
paren
115+
parsable
115116
perf
116117
plugin
117118
pointee

0 commit comments

Comments
 (0)