fix(ui5-link): open new page in correct tab (#13120)

fixes: #13116

Author: tsanislavgatev

packages/main/cypress/specs/Link.cy.tsx

@@ -22,6 +22,16 @@ describe("General API", () => {
 			.should("have.attr", "rel", "noreferrer noopener");
 	});
 
+	it("should not add rel attribute for custom target", () => {
+		cy.mount(<Link href="https://www.sap.com" target="my-target"></Link>);
+
+		cy.get("[ui5-link]")
+			.shadow()
+			.find(".ui5-link-root")
+			.should("have.attr", "target", "my-target")
+			.and("not.have.attr", "rel");
+	});
+
 	it("should wrap the text of the link", () => {
 		cy.mount(
 			<>

packages/main/src/Link.ts

@@ -291,7 +291,7 @@ class Link extends UI5Element implements ITabbable {
 	}
 
 	onBeforeRendering() {
-		const needsNoReferrer = this.target !== "_self"
+		const needsNoReferrer = this.target === "_blank"
 			&& this.href
 			&& this._isCrossOrigin(this.href);
 

packages/main/test/pages/Link.html

@@ -47,6 +47,11 @@ <h2>prevent-default</h2>
 		<ui5-link href="https://www.google.com" target="_self" id="link-click-prevent-default">link click default prevented</ui5-link><span>native span</span>
 	</section>
 
+	<section class="group">
+		<h2>Custom target</h2>
+		<ui5-link href="https://www.sap.com" target="my-target" id="custom-target-link">Custom target link (click multiple times - should reuse same tab)</ui5-link>
+	</section>
+
 	<section class="group">
 		<h2>overstyle-link</h2>
 		<ui5-link href="https://www.google.com" target="_self" style="color: pink">link with different color</ui5-link><span>native span</span>