Skip to content

Commit cf9b982

Browse files
committed
refactor: Cleanups
1 parent 77d044e commit cf9b982

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

.github/workflows/release-please.yml

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -69,23 +69,24 @@ jobs:
6969
with:
7070
node-version: 24.x
7171

72-
- name: Generate npm-shrinkwrap.json (isolated staging)
73-
run: |
74-
set -e
75-
echo "📦 Isolating @ui5/cli for shrinkwrap"
76-
npm ci --omit=dev
77-
STAGE=cli-publish
78-
rm -rf "$STAGE" && mkdir "$STAGE"
79-
echo "↪️ Copying CLI sources"
80-
rsync -a --exclude 'node_modules' packages/cli/ "$STAGE"/
81-
echo "↪️ Copying resolved production dependencies"
82-
rsync -a node_modules/ "$STAGE"/node_modules/
83-
echo "🧹 Pruning extraneous modules inside staging"
84-
(cd "$STAGE" && npm prune --production)
85-
echo "🔒 Running npm shrinkwrap in isolated directory (post-prune)"
86-
(cd "$STAGE" && npm shrinkwrap)
87-
mv "$STAGE"/npm-shrinkwrap.json packages/cli/
88-
echo "✅ npm-shrinkwrap.json placed into packages/cli"
72+
# TODO: Still undecided whether we want to generate shrinkwrap again for the CLI package
73+
# - name: Generate npm-shrinkwrap.json (isolated staging)
74+
# run: |
75+
# set -e
76+
# echo "📦 Isolating @ui5/cli for shrinkwrap"
77+
# npm ci --omit=dev
78+
# STAGE=cli-publish
79+
# rm -rf "$STAGE" && mkdir "$STAGE"
80+
# echo "↪️ Copying CLI sources"
81+
# rsync -a --exclude 'node_modules' packages/cli/ "$STAGE"/
82+
# echo "↪️ Copying resolved production dependencies"
83+
# rsync -a node_modules/ "$STAGE"/node_modules/
84+
# echo "🧹 Pruning extraneous modules inside staging"
85+
# (cd "$STAGE" && npm prune --production)
86+
# echo "🔒 Running npm shrinkwrap in isolated directory (post-prune)"
87+
# (cd "$STAGE" && npm shrinkwrap)
88+
# mv "$STAGE"/npm-shrinkwrap.json packages/cli/
89+
# echo "✅ npm-shrinkwrap.json placed into packages/cli"
8990

9091
- name: Publish @ui5/cli
9192
working-directory: packages/cli

release-please-config.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
3-
"include-component-in-tag": true,
43
"group-pull-request-title-pattern": "release: UI5 CLI packages",
54
"packages": {
65
"packages/logger": {

0 commit comments

Comments
 (0)