Skip to content

Commit f2f3de5

Browse files
pass all parameters that _build_table_properties_exp might use
1 parent 155b884 commit f2f3de5

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

sqlmesh_utils/materializations/non_idempotent_incremental_by_time_range.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,11 @@ def insert(
9292
self.adapter.ctas(
9393
table_name=table_name,
9494
query_or_df=model.ctas_query(**render_kwargs),
95+
table_format=model.table_format,
96+
storage_format=model.storage_format,
97+
partitioned_by=model.partitioned_by,
98+
partition_interval_unit=model.partition_interval_unit,
99+
clustered_by=model.clustered_by,
95100
table_properties=kwargs.get("physical_properties", model.physical_properties),
96101
)
97102

tests/materializations/integration/test_integration_non_idempotent_incremental_by_time_range.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ def mock_merge(**kwargs):
342342
render_kwargs={},
343343
)
344344

345-
# Assert that CTAS was called with table_properties
345+
# Assert that CTAS was called with table_properties and partitioned_by
346346
assert len(ctas_calls) == 1
347347
ctas_kwargs = ctas_calls[0]
348348

@@ -351,3 +351,10 @@ def mock_merge(**kwargs):
351351

352352
assert table_props is not None
353353
assert "extra_props" in table_props
354+
355+
assert "partitioned_by" in ctas_kwargs
356+
partitioned_by = ctas_kwargs["partitioned_by"]
357+
assert partitioned_by == [
358+
exp.Column(this=exp.Identifier(this="category", quoted=True)),
359+
exp.Column(this=exp.Identifier(this="borrowed_at", quoted=True)),
360+
]

0 commit comments

Comments
 (0)