Merge pull request #92 from ThePat02/91-updatemanager-throws-an-error-when-the-editor-is-launched-without-internet-connection

fix: Dirty Update Manager now doesn't die when unable to fetch the plugin version

Author: ThePat02

addons/behaviour_toolkit/behaviour_toolkit.gd

@@ -3,20 +3,41 @@ class_name BehaviourToolkit extends Node
 ## Base class for Behaviour Toolkit plugin nodes.
 
 
+enum LogType {
+    DEFAULT,
+    WARNING,
+    ERROR,
+}
+
+
 class Logger:
     extends BehaviourToolkit
     ## Logger class for Behaviour Toolkit plugin.
 
     ## Main color for logger messages.
     const COLOR_MAIN: String = "Orange"
     ## Accent color for logger messages.
-    const COLOR_ACCENT: String = "Yellow"
+    const COLOR_ACCENT: String = "Blue"
+    ## Warning color for logger messages.
+    const COLOR_WARNING: String = "Yellow"
+    ## Error color for logger messages.
+    const COLOR_ERROR: String = "Red"
 
     ## Log a message to the console with the Behaviour Toolkit prefix.
-    static func say(message: String, caller: Node = null) -> void:
+    static func say(message: String, caller: Node = null, type: LogType = LogType.DEFAULT) -> void:
         var log_message: String
         log_message = colorize("[Behaviour Toolkit] ", COLOR_MAIN)
 
+        if not type == LogType.DEFAULT:
+            var color: String
+            match type:
+                LogType.WARNING:
+                    color = COLOR_WARNING
+                LogType.ERROR:
+                    color = COLOR_ERROR
+            
+            log_message += colorize("[" + LogType.keys()[type] + "] ", color)
+
         if caller != null:
 
             log_message += colorize(caller.name + " ", COLOR_ACCENT)

addons/behaviour_toolkit/ui/utils/update_manager.gd

@@ -16,6 +16,8 @@ signal update_available
 ## The URL to the repository config file. This file has to be the raw version!
 @export var repo_config_url = ""
 
+## Error flag to prevent the error message from printing twice.
+static var had_error: bool = false
 
 ## The current version of the plugin.
 var current_version: String
@@ -24,6 +26,8 @@ var newest_version: String
 
 
 func _ready():
+	current_version = get_current_version()
+
 	# Connect signals
 	connect("request_completed", _on_http_request_request_completed)
 
@@ -36,7 +40,6 @@ func _ready():
 
 func start():
 	# Get versions
-	current_version = get_current_version()
 	get_newest_version()
 
 
@@ -66,6 +69,18 @@ func get_newest_version() -> void:
 
 ## Called when the request to the repository is completed, parses the config file and sets the newest version.
 func _on_http_request_request_completed(result:int, response_code:int, headers:PackedStringArray, body:PackedByteArray):
+	if result != OK:
+		if not had_error:
+			BehaviourToolkit.Logger.say(
+				"Unable to fetch newest version from GitHub. Check your internet connection and reload the editor!",
+				null,
+				BehaviourToolkit.LogType.WARNING
+			)
+			had_error = true
+		
+		emit_signal("update_request_completed")
+		return
+
 	var config = ConfigFile.new()
 	var err = config.parse(body.get_string_from_ascii())