Depend directly on NewPipeExtractor's git repository #12836
+117
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve the Jitpack problems, where sometimes built artifacts disappear. This is not also done for nanojson and FilePicker because: - nanojson is not a gradle project, and thus cannot be built by gradle - FilePicker is using a very old version of gradle, and while that's not a problem when the project is built on its own, when importing is as a subproject it gets built with the same gradle version as NewPipe, which causes gradle issues However, for some reason we've been using the same Jitpack artifacts for the FilePicker and for nanojson since ages without issues, it's just NewPipeExtractor artifacts that sometimes disappear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes in your PR
This is an experimental attempt at replacing Jitpack dependencies (which often stop working and cause CI/local failures) with a direct dependency on a git repository. This relies on the includegit Gradle plugin. I have been using this approach for some time in Dicio's settings.gradle.kts and it has worked well so far, but for NewPipe it works well only to include NewPipeExtractor. There are some issue nanojson and FilePicker because:
However, for some reason we've been using the same Jitpack artifacts for the FilePicker and for nanojson since ages without issues, it's just NewPipeExtractor artifacts that sometimes disappear. And we're going to put FilePicker and nanojson on maven central soon.
So this PR might still be useful, however be aware of the limitations and feel free to reject it. Note that the code could possibly be simplified, as it was designed to handle multiple git dependencies but here we have only one.
A nice thing that this PR introduces is the ability to use a local copy of NewPipeExtractor by just adding
useLocalNewPipeExtractor=truetolocal.properties, instead of having to manually modifysettings.gradle.ktslike before.Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence