Skip to content

Conversation

@theimpulson
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Upgrades AGP to 9.0.0

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Signed-off-by: Aayush Gupta <[email protected]>
AGP 9.0+ requires enabling optimizations

Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Fixes multiple build errors. Once parcelize is fixed, we should be good
to use built-in Kotlin completely

Ref: https://issuetracker.google.com/issues/478401081

Signed-off-by: Aayush Gupta <[email protected]>
@theimpulson theimpulson requested review from Stypox and TobiGr January 29, 2026 07:01
@theimpulson theimpulson added the dependency Issues and PRs related to dependencies label Jan 29, 2026
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jan 29, 2026
@Stypox
Copy link
Member

Stypox commented Feb 1, 2026

Code LGTM and the build seems to run fine. Let's keep an eye on any issues caused by proguard optimizations after merging. Thanks!

@theimpulson theimpulson merged commit 15b5cef into dev Feb 1, 2026
6 checks passed
@theimpulson theimpulson deleted the agp9 branch February 1, 2026 09:36
@dustdfg
Copy link
Contributor

dustdfg commented Feb 2, 2026

Probably introduced #13183

@theimpulson
Copy link
Member Author

Probably introduced #13183

Not merged in refactor or ported

@dustdfg
Copy link
Contributor

dustdfg commented Feb 3, 2026

Probably introduced #13183

Not merged in refactor or ported

Nightly not nightly-refactor. And you don't need nightly at all, you need just to compile dev in release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency Issues and PRs related to dependencies size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants