Merge pull request #124 from SumoLogic/hpal_nodejs_upgrade

himanshu219 · web-flow · commit 1fdeac575246 · 2025-03-07T00:32:13.000+05:30
SUMO-256677: upgraded node version to node20
diff --git a/.github/workflows/eslint-validation-test.yaml b/.github/workflows/eslint-validation-test.yaml
@@ -0,0 +1,33 @@
+name: "ESLint validation tests"
+on: [workflow_dispatch, pull_request]
+
+jobs:
+  eslint-validation-test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix: 
+        include: # Includes one more job
+          - dir: 'BlockBlobReader/target/consumer_build'
+          - dir: 'BlockBlobReader/target/dlqprocessor_build'
+          - dir: 'BlockBlobReader/target/producer_build'
+          - dir: 'AppendBlobReader/target/producer_build'
+          - dir: 'AppendBlobReader/target/appendblob_producer_build'
+          - dir: 'AppendBlobReader/target/consumer_build'
+          - dir: 'AppendBlobReader/target/consumer_build'
+          - dir: 'AppendBlobReader/target/consumer_build'
+          - dir: 'EventHubs/target/metrics_build'
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
+      - name: Run ESLint
+        working-directory: ${{ matrix.dir }}
+        run: |
+          npm install eslint globals @eslint/js
+          cp ../../../eslint.config.mjs .
+          npx eslint . --ext .js
diff --git a/.github/workflows/syntax-validation-test.yaml b/.github/workflows/syntax-validation-test.yaml
@@ -2,7 +2,7 @@ name: "Syntax validation tests"
 on: [workflow_dispatch, pull_request]
 
 jobs:
-  package-version-test:
+  node-syntax-test:
     runs-on: ubuntu-latest
     strategy:
       matrix: 
@@ -23,7 +23,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
       
       - working-directory: ${{ matrix.dir }}
         run: |
diff --git a/AppendBlobReader/src/appendblobreaderdeploy.json b/AppendBlobReader/src/appendblobreaderdeploy.json
@@ -541,7 +541,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
@@ -640,7 +640,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
@@ -751,7 +751,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
diff --git a/BlockBlobReader/src/blobreaderdeploy.json b/BlockBlobReader/src/blobreaderdeploy.json
@@ -378,7 +378,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "Project",
@@ -505,7 +505,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
@@ -596,7 +596,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
diff --git a/BlockBlobReader/src/blobreaderdeploywithPremiumPlan.json b/BlockBlobReader/src/blobreaderdeploywithPremiumPlan.json
@@ -376,7 +376,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "Project",
@@ -503,7 +503,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
@@ -594,7 +594,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "FUNCTION_APP_EDIT_MODE",
diff --git a/BlockBlobReader/src/blobreaderzipdeploy.json b/BlockBlobReader/src/blobreaderzipdeploy.json
@@ -366,7 +366,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "Project",
@@ -491,7 +491,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "WEBSITE_RUN_FROM_PACKAGE",
@@ -580,7 +580,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "WEBSITE_RUN_FROM_PACKAGE",
diff --git a/EventHubs/src/azuredeploy_metrics.json b/EventHubs/src/azuredeploy_metrics.json
@@ -218,7 +218,7 @@
                         },
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
-                            "value": "~18"
+                            "value": "~20"
                         },
                         {
                             "name": "Project",
diff --git a/deletetestresourcegroups.py b/deletetestresourcegroups.py
@@ -7,14 +7,14 @@
 from sumologic import SumoLogic
 
 config = {
-    "AZURE_SUBSCRIPTION_ID": "",
-    "AZURE_CLIENT_ID": "",
-    "AZURE_CLIENT_SECRET": "",
-    "AZURE_TENANT_ID": "",
-    "AZURE_DEFAULT_REGION": "",
-    "SUMO_ACCESS_ID": "",
-    "SUMO_ACCESS_KEY": "",
-    "SUMO_DEPLOYMENT": "us1"
+    "AZURE_SUBSCRIPTION_ID": os.environ.get("AZURE_SUBSCRIPTION_ID"),
+    "AZURE_CLIENT_ID": os.environ.get("AZURE_CLIENT_ID"),
+    "AZURE_CLIENT_SECRET": os.environ.get("AZURE_CLIENT_SECRET"),
+    "AZURE_TENANT_ID": os.environ.get("AZURE_TENANT_ID"),
+    "AZURE_DEFAULT_REGION": os.environ.get("AZURE_DEFAULT_REGION"),
+    "SUMO_ACCESS_ID": os.environ.get("SUMO_ACCESS_ID"),
+    "SUMO_ACCESS_KEY": os.environ.get("SUMO_ACCESS_KEY"),
+    "SUMO_DEPLOYMENT": os.environ.get("SUMO_DEPLOYMENT")
 }
 
 # config_file = os.path.expanduser("~/.azure/azure_credentials.json")
@@ -27,8 +27,6 @@
 )
 location = str(config['AZURE_DEFAULT_REGION'])
 
-print("creating credentials", subscription_id)
-
 resource_client = ResourceManagementClient(credentials, subscription_id)
 
 
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,10 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {files: ["**/*.js"], languageOptions: {sourceType: "commonjs"}},
+  {languageOptions: { globals: globals.browser }},
+  pluginJs.configs.recommended,
+];

Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,7 @@`
`541`	`541`	`},`
`542`	`542`	`{`
`543`	`543`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`544`		`- "value": "~18"`
	`544`	`+ "value": "~20"`
`545`	`545`	`},`
`546`	`546`	`{`
`547`	`547`	`"name": "FUNCTION_APP_EDIT_MODE",`
`@@ -640,7 +640,7 @@`
`640`	`640`	`},`
`641`	`641`	`{`
`642`	`642`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`643`		`- "value": "~18"`
	`643`	`+ "value": "~20"`
`644`	`644`	`},`
`645`	`645`	`{`
`646`	`646`	`"name": "FUNCTION_APP_EDIT_MODE",`
`@@ -751,7 +751,7 @@`
`751`	`751`	`},`
`752`	`752`	`{`
`753`	`753`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`754`		`- "value": "~18"`
	`754`	`+ "value": "~20"`
`755`	`755`	`},`
`756`	`756`	`{`
`757`	`757`	`"name": "FUNCTION_APP_EDIT_MODE",`
Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@`
`378`	`378`	`},`
`379`	`379`	`{`
`380`	`380`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`381`		`- "value": "~18"`
	`381`	`+ "value": "~20"`
`382`	`382`	`},`
`383`	`383`	`{`
`384`	`384`	`"name": "Project",`
`@@ -505,7 +505,7 @@`
`505`	`505`	`},`
`506`	`506`	`{`
`507`	`507`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`508`		`- "value": "~18"`
	`508`	`+ "value": "~20"`
`509`	`509`	`},`
`510`	`510`	`{`
`511`	`511`	`"name": "FUNCTION_APP_EDIT_MODE",`
`@@ -596,7 +596,7 @@`
`596`	`596`	`},`
`597`	`597`	`{`
`598`	`598`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`599`		`- "value": "~18"`
	`599`	`+ "value": "~20"`
`600`	`600`	`},`
`601`	`601`	`{`
`602`	`602`	`"name": "FUNCTION_APP_EDIT_MODE",`
Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@`
`376`	`376`	`},`
`377`	`377`	`{`
`378`	`378`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`379`		`- "value": "~18"`
	`379`	`+ "value": "~20"`
`380`	`380`	`},`
`381`	`381`	`{`
`382`	`382`	`"name": "Project",`
`@@ -503,7 +503,7 @@`
`503`	`503`	`},`
`504`	`504`	`{`
`505`	`505`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`506`		`- "value": "~18"`
	`506`	`+ "value": "~20"`
`507`	`507`	`},`
`508`	`508`	`{`
`509`	`509`	`"name": "FUNCTION_APP_EDIT_MODE",`
`@@ -594,7 +594,7 @@`
`594`	`594`	`},`
`595`	`595`	`{`
`596`	`596`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`597`		`- "value": "~18"`
	`597`	`+ "value": "~20"`
`598`	`598`	`},`
`599`	`599`	`{`
`600`	`600`	`"name": "FUNCTION_APP_EDIT_MODE",`
Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@`
`366`	`366`	`},`
`367`	`367`	`{`
`368`	`368`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`369`		`- "value": "~18"`
	`369`	`+ "value": "~20"`
`370`	`370`	`},`
`371`	`371`	`{`
`372`	`372`	`"name": "Project",`
`@@ -491,7 +491,7 @@`
`491`	`491`	`},`
`492`	`492`	`{`
`493`	`493`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`494`		`- "value": "~18"`
	`494`	`+ "value": "~20"`
`495`	`495`	`},`
`496`	`496`	`{`
`497`	`497`	`"name": "WEBSITE_RUN_FROM_PACKAGE",`
`@@ -580,7 +580,7 @@`
`580`	`580`	`},`
`581`	`581`	`{`
`582`	`582`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`583`		`- "value": "~18"`
	`583`	`+ "value": "~20"`
`584`	`584`	`},`
`585`	`585`	`{`
`586`	`586`	`"name": "WEBSITE_RUN_FROM_PACKAGE",`
Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@`
`218`	`218`	`},`
`219`	`219`	`{`
`220`	`220`	`"name": "WEBSITE_NODE_DEFAULT_VERSION",`
`221`		`- "value": "~18"`
	`221`	`+ "value": "~20"`
`222`	`222`	`},`
`223`	`223`	`{`
`224`	`224`	`"name": "Project",`