--include-sparse deprecated

[mbstrange2]

garnet/mflowgen/common/rtl/gen_rtl.sh

Line 75 in 020c9b7

[ "$WHICH_SOC" != "amber" ] && flags+=" --include-sparse"

I don't think this flag --include-sparse exists anymore (or even in the repo at the point of this change)

[steveri]

Thanks Max! I will look into it.
Just out of curiosity...how did you find this?
Just browsing around, or actively looking for bugs?

[mbstrange2]

I am trying to run the PD flow in GF and stumbled across this. I think this really stems from PD being run outside of the aha repo/docker image, so the command in garnet main gets out of sync with the arguments of garnet.py depending on the version in StanfordAHA:garnet/latest - to be fair, though, there are so many different versions of everything that maybe I have convinced myself of a problem that doesn't exist 😅

[steveri]

I think this really stems from PD being run outside of the aha repo/docker image,

So...are you thinking garnet PD should only be run from inside a docker container...? I.e. we could put a warning or error if someone tried to run gen_rtl from a non-docker environment...?

[steveri]

Believe it or not I am still working on this.
Unfortunately, all of garnet is broken at the moment, because of a recent mflowgen-repo update.
So I need to get that fixed on the way to getting this done, and itlooks like that will still take a while longer.
Unless this is currently in someone's critical path, in which case I can bump it up...