Piglin Barter Drops are Biased

[JustAHuman-xD]

❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I downloaded the official version from the new build site Blob Builds.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

The piglin barter drop recipe type uses a hashset and iterates over it when generating the custom drop, the hash set, after its done being modified (post finalized event) will have a deterministic order for the runtime of the server.

Because of this, the items at the beginning of the iteration order have a bias towards being dropped.

📑 Reproduction Steps

Look at the code

💡 Expected Behavior

Drops would be properly randomized always

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Spigot

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

🧭 Other plugins

No response