Rule sets must appear in the order present in PhpCsFixer\RuleSet

Author: Slamdunk

lib/Config.php

@@ -10,9 +10,9 @@
 
 final class Config extends PhpCsFixerConfig
 {
-    const APP_V1    = 'APP_V1';
-    const APP_V2    = 'APP_V2';
-    const LIB       = 'LIB';
+    public const APP_V1    = 'APP_V1';
+    public const APP_V2    = 'APP_V2';
+    public const LIB       = 'LIB';
 
     public function __construct(string $type = self::APP_V2, array $overriddenRules = [])
     {
@@ -36,12 +36,12 @@ public function __construct(string $type = self::APP_V2, array $overriddenRules
         ]);
 
         $rules = [
+            '@Symfony'                                      => true,
+            '@Symfony:risky'                                => true,
             '@DoctrineAnnotation'                           => true,
             '@PHP71Migration'                               => true,
             '@PHP71Migration:risky'                         => true,
-            '@PHPUnit60Migration:risky'                     => true,
-            '@Symfony'                                      => true,
-            '@Symfony:risky'                                => true,
+            '@PHPUnit75Migration:risky'                     => true,
             'Slam/final_abstract_public'                    => self::APP_V1 !== $type,
             'Slam/final_internal_class'                     => self::APP_V1 !== $type,
             'Slam/function_reference_space'                 => true,
@@ -110,7 +110,6 @@ public function __construct(string $type = self::APP_V2, array $overriddenRules
             'ordered_class_elements'                        => ['order' => ['use_trait', 'constant_public', 'constant_protected', 'constant_private', 'property', 'construct', 'destruct', 'magic', 'phpunit', 'method']],
             'ordered_imports'                               => true,
             'ordered_interfaces'                            => true,
-            'php_unit_dedicate_assert_internal_type'        => true,
             'php_unit_internal_class'                       => false,
             'php_unit_method_casing'                        => true,
             'php_unit_ordered_covers'                       => true,

tests/ConfigTest.php

@@ -48,7 +48,7 @@ public function testAllDefaultRulesAreSpecified()
         $fixerFactory->registerCustomFixers($config->getCustomFixers());
         $fixers = $fixerFactory->getFixers();
 
-        $availableRules = \array_filter($fixers, function (FixerInterface $fixer) {
+        $availableRules = \array_filter($fixers, static function (FixerInterface $fixer) {
             return ! $fixer instanceof DeprecatedFixerInterface;
         });
         $availableRules = \array_map(function (FixerInterface $fixer) {
@@ -62,7 +62,17 @@ public function testAllDefaultRulesAreSpecified()
         $diff = \array_diff($currentRules, $availableRules);
         static::assertEmpty($diff, \sprintf("I seguenti fixer sono di troppo:\n- %s", \implode(\PHP_EOL . '- ', $diff)));
 
-        $currentRules        = \array_keys($configRules);
+        $currentSets = \array_values(\array_filter(\array_keys($configRules), static function (string $fixerName): bool {
+            return isset($fixerName[0]) && '@' === $fixerName[0];
+        }));
+        $defaultSets   = $ruleSet->getSetDefinitionNames();
+        $intersectSets = \array_values(\array_intersect($defaultSets, $currentSets));
+        static::assertEquals($intersectSets, $currentSets, \sprintf('Rule sets must be ordered as the appear in %s', RuleSet::class));
+
+        $currentRules = \array_values(\array_filter(\array_keys($configRules), static function (string $fixerName): bool {
+            return isset($fixerName[0]) && '@' !== $fixerName[0];
+        }));
+
         $orderedCurrentRules = $currentRules;
         \sort($orderedCurrentRules);
         static::assertEquals($orderedCurrentRules, $currentRules, 'Order the rules alphabetically please');