Skip to content

Commit 3c499d0

Browse files
authored
Merge pull request #1387 from Shopify/pz-serialize-benchmark-refactor
Refactor render_layout method for serialization
2 parents 260c863 + e71e53f commit 3c499d0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

performance/theme_runner.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,14 @@ def render
7373

7474
private
7575

76+
def render_layout(template, layout, assigns)
77+
assigns['content_for_layout'] = template.render!(assigns)
78+
layout&.render!(assigns)
79+
end
80+
7681
def compile_and_render(template, layout, assigns, page_template, template_file)
77-
compiled_test = compile_test(template, layout, assigns, page_template, template_file)
78-
assigns['content_for_layout'] = compiled_test[:tmpl].render!(assigns)
79-
compiled_test[:layout].render!(assigns) if layout
82+
compiled_test = compile_test(template, layout, assigns, page_template, template_file)
83+
render_layout(compiled_test[:tmpl], compiled_test[:layout], compiled_test[:assigns])
8084
end
8185

8286
def compile_all_tests

0 commit comments

Comments
 (0)